v0.2.52..v0.2.53 changeset BuildingCriterion.cpp
Garret Voltz edited this page Feb 12, 2020
·
1 revision
diff --git a/hoot-core/src/main/cpp/hoot/core/criterion/BuildingCriterion.cpp b/hoot-core/src/main/cpp/hoot/core/criterion/BuildingCriterion.cpp
index 65a0cbe..28bc746 100644
--- a/hoot-core/src/main/cpp/hoot/core/criterion/BuildingCriterion.cpp
+++ b/hoot-core/src/main/cpp/hoot/core/criterion/BuildingCriterion.cpp
@@ -22,7 +22,7 @@
* This will properly maintain the copyright information. DigitalGlobe
* copyrights will be updated automatically.
*
- * @copyright Copyright (C) 2015, 2017, 2018, 2019 DigitalGlobe (http://www.digitalglobe.com/)
+ * @copyright Copyright (C) 2015, 2017, 2018, 2019, 2020 DigitalGlobe (http://www.digitalglobe.com/)
*/
#include "BuildingCriterion.h"
@@ -78,6 +78,8 @@ bool BuildingCriterion::isSatisfied(const ConstElementPtr& e) const
{
bool result = false;
+ LOG_VART(e->getElementId());
+
// if it is a building
LOG_VART(e->getElementType() == ElementType::Node);
@@ -86,10 +88,10 @@ bool BuildingCriterion::isSatisfied(const ConstElementPtr& e) const
if ((e->getElementType() != ElementType::Node) &&
(OsmSchema::getInstance().hasCategory(e->getTags(), "building") == true))
{
- // If a map was set, then we assume the parent is to be checked as well. This is a little
+ // If a map was set, then we assume the parent is to be checked as well. This is a little
// messy but reflects how the logic worked before moving OsmSchema feature type method logic
- // out to criterion. Another option could be to make two separate criteria, one that checks
- // the parent and one that doesn't.
+ // out to criterion. We may still want to rethink allowing a null map. Another option could be
+ // to make two separate criteria, one that checks the parent and one that doesn't.
LOG_VART(_map.get());
if (!_map || isParentABuilding(e->getElementId()) == false)
{