v0.2.51..v0.2.52 changeset ChangesetReplacementCreatorTest.cpp

diff --git a/hoot-core-test/src/test/cpp/hoot/core/algorithms/changeset/ChangesetReplacementCreatorTest.cpp b/hoot-core-test/src/test/cpp/hoot/core/algorithms/changeset/ChangesetReplacementCreatorTest.cpp
new file mode 100644
index 0000000..074cf10
--- /dev/null
+++ b/hoot-core-test/src/test/cpp/hoot/core/algorithms/changeset/ChangesetReplacementCreatorTest.cpp
@@ -0,0 +1,244 @@
+/*
+ * This file is part of Hootenanny.
+ *
+ * Hootenanny is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * --------------------------------------------------------------------
+ *
+ * The following copyright notices are generated automatically. If you
+ * have a new notice to add, please use the format:
+ * " * @copyright Copyright ..."
+ * This will properly maintain the copyright information. DigitalGlobe
+ * copyrights will be updated automatically.
+ *
+ * @copyright Copyright (C) 2019 DigitalGlobe (http://www.digitalglobe.com/)
+ */
+
+// Hoot
+#include <hoot/core/TestUtils.h>
+#include <hoot/core/algorithms/changeset/ChangesetReplacementCreator.h>
+#include <hoot/core/util/Log.h>
+#include <hoot/core/ops/MergeNearbyNodes.h>
+#include <hoot/core/criterion/TagCriterion.h>
+#include <hoot/core/util/GeometryUtils.h>
+
+namespace hoot
+{
+
+/*
+ * This only tests some input validation checks, as its easier to test the actual changeset
+ * generation from command line tests (ServiceChangesetReplacement*Test.sh), as you can see the
+ * results of applying the changesets back to the source data.
+ */
+class ChangesetReplacementCreatorTest : public HootTestFixture
+{
+  CPPUNIT_TEST_SUITE(ChangesetReplacementCreatorTest);
+  CPPUNIT_TEST(runInvalidGeometryFilterTest);
+  CPPUNIT_TEST(runInvalidReplacementFilterTest);
+  CPPUNIT_TEST(runInvalidRetainmentFilterTest);
+  CPPUNIT_TEST(runNonBoundableReaderTest);
+  CPPUNIT_TEST(runGeoJsonTest);
+  CPPUNIT_TEST(runInvalidFilterConfigOptsTest);
+  CPPUNIT_TEST(runConvertOpsTest);
+  CPPUNIT_TEST(runFullReplacmentWithRetainmentFilterTest);
+  CPPUNIT_TEST_SUITE_END();
+
+public:
+
+  ChangesetReplacementCreatorTest()
+  {
+  }
+
+  void runInvalidGeometryFilterTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+    try
+    {
+      changesetCreator.setGeometryFilters(QStringList("hoot::TagCriterion"));
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT(exceptionMsg.startsWith("Invalid feature geometry type filter"));
+  }
+
+  void runInvalidReplacementFilterTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+
+    try
+    {
+      changesetCreator.setReplacementFilters(QStringList("hoot::AddAttributesVisitor"));
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT(exceptionMsg.startsWith("Invalid additional input filter"));
+
+    try
+    {
+      changesetCreator.setReplacementFilters(QStringList("hoot::PoiCriterion"));
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT(exceptionMsg.startsWith("Invalid additional input filter"));
+  }
+
+  void runInvalidRetainmentFilterTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+
+    try
+    {
+      changesetCreator.setRetainmentFilters(QStringList("hoot::AddAttributesVisitor"));
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT(exceptionMsg.startsWith("Invalid additional input filter"));
+
+    try
+    {
+      changesetCreator.setRetainmentFilters(QStringList("hoot::PoiCriterion"));
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT(exceptionMsg.startsWith("Invalid additional input filter"));
+  }
+
+  void runNonBoundableReaderTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+    try
+    {
+      changesetCreator.create(
+        "test-files/cmd/quick/ConvertGeoNames.geonames", "test2.osm", geos::geom::Envelope(),
+        "out.osm");
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+
+    CPPUNIT_ASSERT(
+      exceptionMsg.endsWith("must implement Boundable for replacement changeset derivation."));
+  }
+
+  void runGeoJsonTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+    try
+    {
+      changesetCreator.create("test1.geojson", "test2.osm", geos::geom::Envelope(), "out.osm");
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT_EQUAL(
+      QString("GeoJSON inputs are not supported by replacement changeset derivation.").toStdString(),
+      exceptionMsg.toStdString());
+  }
+
+  void runInvalidFilterConfigOptsTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+
+    // the filter can be any non-geometry crit here
+    changesetCreator.setReplacementFilters(
+      QStringList(QString::fromStdString(TagCriterion::className())));
+    try
+    {
+      changesetCreator.setReplacementFilterOptions(QStringList("blah"));
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT(exceptionMsg.startsWith("Invalid filter configuration option"));
+
+    // the filter can be any non-geometry crit here
+    changesetCreator.setRetainmentFilters(
+      QStringList(QString::fromStdString(TagCriterion::className())));
+    try
+    {
+      changesetCreator.setRetainmentFilterOptions(QStringList("blah"));
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT(exceptionMsg.startsWith("Invalid filter configuration option"));
+  }
+
+  void runConvertOpsTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+    // the convert ops added here can contain any op
+    conf().set(
+      ConfigOptions::getConvertOpsKey(),
+      QStringList(QString::fromStdString(MergeNearbyNodes::className())));
+    try
+    {
+      changesetCreator.create("test1.osm", "test2.osm", geos::geom::Envelope(), "out.osm");
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT_EQUAL(
+      QString("Replacement changeset derivation does not support convert operations.").toStdString(),
+      exceptionMsg.toStdString());
+  }
+
+  void runFullReplacmentWithRetainmentFilterTest()
+  {
+    QString exceptionMsg;
+    ChangesetReplacementCreator changesetCreator;
+    changesetCreator.setFullReplacement(true);
+    // the filter can be any non-geometry crit here
+    changesetCreator.setRetainmentFilters(
+      QStringList(QString::fromStdString(TagCriterion::className())));
+    try
+    {
+      changesetCreator.create("test1.osm", "test2.osm", geos::geom::Envelope(), "out.osm");
+    }
+    catch (const HootException& e)
+    {
+      exceptionMsg = e.what();
+    }
+    CPPUNIT_ASSERT_EQUAL(
+      QString("Both full reference data replacement and a reference data retainment filter may not "
+              "be specified for replacement changeset derivation.").toStdString(),
+      exceptionMsg.toStdString());
+  }
+};
+
+CPPUNIT_TEST_SUITE_NAMED_REGISTRATION(ChangesetReplacementCreatorTest, "quick");
+
+}