Upgrade to JTS 1.15

• Contact: jodygarnett
• Tracker: https://osgeo-org.atlassian.net/browse/GEOT-5954
• TLDR: Coordinate upgrade to JTS 1.15 which changes package and license
• Link to in progress details Google Doc.

Description

We would like to upgrade to the current version of JTS!

JTS 1.15 has migrated to LocationTech:

• the package has changed to org.locationtech.jts
• the license has changed to our choice of BSD or EPL, this proposal recommends we go with BSD

The project now has official releases at maven central (we are not sure who uploaded prior releases):

• org.locationtech.jts.jts-core-1.15.1.jar
• org.locationtech.jts.jts-io-common-1.15.1.jar

References:

• JTS Topology Suite (LocationTech)
• JTS 1.15.0 (GitHub)
• JTS Migration Guide (GitHub)

Coordinated upgrade

GeoTools does not exist in isolation, as part of the FOSS4GNA code sprint Jim short listed a number of community projects which need to update in a coordinated fashion:

1. geotools

   • https://osgeo-org.atlassian.net/browse/GEOT-5954
   • PR works on Mac, windows build fails on gt-svg DrawTest
   • PR #1944
   • ✅ done!

2. geoserver

   • https://osgeo-org.atlassian.net/browse/GEOS-8761

   • initial failure

     Failed tests:   testGetFeatureContent(org.geoserver.test.Gsml32BoreholeIntervalWfsTest): expected:<[#borehole.shape.GA.17322]> but was:<[]>
     

   • Failure was a regression in clone method, resolved with release of jts-1.15.1

   • ✅ PR #2945

3. geowebcache

   • https://github.com/GeoWebCache/geowebcache/issues/652
   • PR works on mac, windows build fails on arcgis server tile cache support
   • PR #663

4. jai-ext

   • https://github.com/geosolutions-it/jai-ext/issues/182
   • upgraded to JTS 1.15.0
   • removed use of ExtendedCoordinate as unnecessary
   • ✅ PR #19ht

5. jaitools

   • long term functionality is moving to JAI-EXT above
   • PR #234
   • ✅ jody merged, James is deploying to maven central

6. geodb

   • PR #28 upgrading to jts - merged!
   • PR [#29](https://github.com/jdeolive/geodb/pull/29] to use as a 0.9 tag
   • Deployed to repo.boundlessgeo.com while we wait for the above
   • ✅ ready!

7. hatbox

   • Issue requesting update: https://sourceforge.net/p/hatbox/bugs/5/
   • Diff attached to issue 5 above, available here https://github.com/jodygarnett/hatbox
   • Deployed net.sourceforge.hatbox-1.0-b10 to repo.boundlessgeo.com while we wait
   • ✅ ready
   • ⚠️ although we would like to see the diff applied to svn above

8. java-vector-tile

   • PR to update to JTS 1.15.0 has been merged.
   • Version 1.3.1 is being released [here|https://github.com/ElectronicChartCentre/ecc-mvn-repo/tree/master/releases/no/ecc/vectortile/java-vector-tile/1.3.1]
   • Published to Boundless Repo (done)
   • ✅ ready

9. Provide update instructions in GeoTools user guide

   • PR#1959

Status

Choose one of:

• Under Discussion
• In Progress
• Completed
• Rejected,
• Deferred

Voting:

• Andrea Aime: +1
• Ben Caradoc-Davies: +1
• Ian Turton: +1
• Jody Garnett: +1
• Simone Giannecchini: +0

Tasks

1. Follow the migration guide to bulk search and replace pom.xml and java references

git grep -l com.vividsolutions | grep pom.xml | xargs sed -i "s/com.vividsolutions/org.locationtech.jts/g"
git grep -l com.vividsolutions | xargs sed -i "s/com.vividsolutions/org.locationtech/g"

2. Run code formatter to fix order of imports

3. Update User Guide examples? They should be captured by the sed command above ...

4. Make a note in the geotools upgrade.rst instructions

API Change

Maven Dedependency

Before: com.vividsolutions jts-core 1.14.0

After: org.locationtech.jts jts-core ${jts.version}

(With ${jts.version} >= 1.15.0.)

Library Use

Before:

import com.vividsolutions.jts.*;

After:

import org.locationtech.jts.*;