Lockscreen bug fixes #1509
Merged
Lockscreen bug fixes #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed black screen when lock screen is presented in background
This was referenced Dec 12, 2019
joeljfischer
suggested changes
Dec 13, 2019
joeljfischer
suggested changes
Dec 13, 2019
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
suggested changes
Dec 18, 2019
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…ttps://github.com/smartdevicelink/sdl_ios into bugfix/issues_1480_1492_1496_1501_lockscreen_fixes
joeljfischer
suggested changes
Jan 2, 2020
This was referenced Jan 2, 2020
joeljfischer
suggested changes
Jan 2, 2020
joeljfischer
approved these changes
Jan 3, 2020
joeljfischer
deleted the
bugfix/issues_1480_1492_1496_1501_lockscreen_fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1480, #1492, #1496, #1501
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Fixed unit test cases for the lock screen.
Core Tests
Smoke tests performed
Core version / branch / commit hash / module tested against: SYNC 3 v.3.4
HMI name / version / branch / commit hash / module tested against: SYNC 3 v3.4
Summary
Fixed numerous issues with showing and dismissing the lock screen when the app has multiple
UIWindows.SDLScreenshotViewControllerclass as no screenshot is needed to animate the transition and replaced it with theSDLLockScreenRootViewControllerclass as it is needed to fix the status bar rotation bug.UIWindowis now created the first time the lock screen is presented and it is hidden when the lock screen is dismissed. When the session with the head unit is closed, the lock screen window is destroyed. Doing this means we don't have to keep track of the window over which the lock screen is being presented (Apple adds it's own privateUIWindowfor the keyboard to the app so it is not as simple as grabbing the last window on theUIApplication'swindowsarray. Also there is no guarantee the top-most window is the currently visible content as the window could be clear or offscreen).Changelog
Bug Fixes
UIWindowbeing set when the lock screen was dismissed.UIWindowbeing created as soon as the SDL app was started. Now it is created on the first presentation of the lock screen and destroyed when the session is closed.Tasks Remaining:
CLA