Only create lockscreen UIWindow as needed #1498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lock screen window is destroyed after it has been dismissed
NicoleYarroch
changed the title
joeljfischer
suggested changes
Dec 12, 2019
There was a problem hiding this comment.
The lock screen is appearing totally broken for me using the ObjC example app. The app, even when the lock screen shouldn't be displayed, is totally black. When the lock screen is "on" the app is totally black with an icon in the top left corner, cut off. This only happens if the head unit is set to DD_OFF when the app connects.
|
Closing in favor of PR #1509 as pretty much all the code affected in this PR was changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1496
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit test cases were run.
Core Tests
Core version / branch / commit hash / module tested against: SYNC 3, v3.0
HMI name / version / branch / commit hash / module tested against: SYNC 3, v3.0
Summary
The lock screen window is now created when the lock screen is presented and destroyed when the lock screen is dismissed. This prevents a lock screen
UIWindowfrom being added to[UIApplication sharedApplication].windowsunnecessarily when the SDL app starts as the user may never connect to a head unit.Changelog
Bug Fixes
UIWindowis now created on presentation and destroyed on dismissal instead of being created immediately and persisting thought the app session.Tasks Remaining:
CLA