LockScreen bounds should always be full bounds of Main screen #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
approved these changes
Dec 10, 2019
|
Waiting for issue reporter |
joeljfischer
changed the title
|
Closed in favor of #1509 |
joeljfischer
deleted the
bugfix/issue-1492-SDLLockScreenViewController-abnormalUI
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1492
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
There are no unit tests for this class
Core Tests
Tested against TDK
Summary
Made the lockscreen always be the full size of the phone screen when presented
Bug Fixes
Fixes the issue that sets the lockscreen to the size of the
appWindow, in some cases the appWIndow may not be the full size of the screen. This can cause issues with how the lockscreen looks when presented.CLA