Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL lockscreen UIWindow create too early sometimes block app popview. #1496

Closed
84798012 opened this issue Dec 10, 2019 · 5 comments
Closed
Assignees
Labels
bug A defect in the library

Comments

@84798012
Copy link

Bug Report

[Summary]
SDL created an UIWindow when SDLManager is initialized, it's too early.
This hided UIWindow in some case will block main app's viewcontroller show.

(Suggestion: lockscreen UIWindow can be created just when it needs to present)

Reproduction Steps

Just see the demo link below.

Expected Behavior

Main app pop view controller can show well.

Observed Behavior

Main app pop view controller always can not showed.

OS & Version Information
  • iOS Version: [What version of iOS are you using when the bug occurred]
    v13.1.3
  • SDL iOS Version: [What version of the library has this bug been seen on]
    v6.4.1
Test Case, Sample Code, and / or Example App

https://github.com/84798012/SDL_Window_Rotate_Bug_Reproduce_Demo/tree/master/blockPopIssue

@joeljfischer joeljfischer added the bug A defect in the library label Dec 10, 2019
@NicoleYarroch
Copy link
Contributor

@84798012 What branch were you using when you found this bug? Where you using branch bugfix/issue-1480-recreate-lockVC-every-time used in the Recreate the lock screen view controller PR or were you using the master branch (v.6.4.1)?

@84798012
Copy link
Author

Thanks.
Seems been fixed.

@84798012
Copy link
Author

fixed, so close it.

@joeljfischer
Copy link
Contributor

@84798012 Could you please re-test this bug using PR #1509? We ended up doing a large refactor of the lock screen code and would like to confirm that it still fixes all of your issues. Thank you!

@84798012
Copy link
Author

I have test on 1509, the issue fixed. Thanks!

@joeljfischer joeljfischer mentioned this issue Jan 7, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

No branches or pull requests

3 participants