Recreate the lock screen view controller

[joeljfischer]

Fixes #1480

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

• I have verified that I have not introduced new warnings in this PR (or explain why below)
• I have run the unit tests with this PR
• I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

No unit tests were added.

Core Tests

• Displaying and hiding the lock screen verified 10x in a row.
• Additional verification will be requested from the issue reporter.

Core version / branch / commit hash / module tested against: Sync Gen 3.4 19317_DEVTEST
HMI name / version / branch / commit hash / module tested against: n/a

Summary

This PR changes the SDLScreenshotViewController from being created once when the SDLLockScreenPresenter is initialized to creating it every time the lock screen is going to be created and destroying it when the lock screen dismisses.

Changelog

Bug Fixes

• Fix the lock window not taking the app's window's characteristics if the app's window changes.

CLA

• I have signed the CLA

[joeljfischer]

Closed in favor of #1509