LockScreen Dismiss animation #1507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed in favor of #1509 |
joeljfischer
deleted the
bugfix/issue-1504-LockScreen-Dismiss-Animation-Breaks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1504
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Core Tests
Tested Lockscreen animation to make sure that dismiss is called once and the screen dismiss animation is shown
Core version / branch / commit hash / module tested against: TDK, SYNC 3, V3.0
Summary
Made a change that makes sure the dismiss lock screen is only fired once so the animation can occur
Bug Fixes
dismissViewControllerAnimated was being called twice causing issues with the lockscreen animation
CLA