Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock screen dismiss animation breaks #1504

Closed
NicoleYarroch opened this issue Dec 11, 2019 · 4 comments
Closed

Lock screen dismiss animation breaks #1504

NicoleYarroch opened this issue Dec 11, 2019 · 4 comments
Assignees
Labels
bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen
Projects

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

The lock screen dismiss animation breaks the first time the lock screen is shown.

Reproduction Steps
  1. App is open on phone
  2. TDK is set to "parked"
  3. Connect app to TDK (SYNC 3 v3.0)
Expected Behavior

The lock screen should show and be dismissed since the vehicle is not moving. The dismissal of the lock screen should be animated.

Observed Behavior

The lock screen should show and be dismissed since the vehicle is not moving. The lock screen dismissal is not animated.

I believe this is because dismiss is called twice in quick succession
due to two driver distraction notifications coming in one right after another. We should probably check if the lock screen is already in the process of being dismissed before doing the dismissal.

OS & Version Information
  • iOS Version: 13
  • SDL iOS Version: 6.4.1
  • Testing Against: TDK, SYNC 3, v3.0
@NicoleYarroch
Copy link
Contributor Author

I think this was the bug @SatbirTanda was describing in another lockscreen PR?

@NicoleYarroch
Copy link
Contributor Author

@NicoleYarroch NicoleYarroch added the bug A defect in the library label Dec 11, 2019
@joeljfischer
Copy link
Contributor

@NicoleYarroch Does #1509 fix this?

@NicoleYarroch
Copy link
Contributor Author

Note: I believe this bug can only be reproduced on SYNC 3 v.3.0

@joeljfischer joeljfischer added the manager-lockscreen Relating to the manager layer - lockscreen label Jan 28, 2020
@joeljfischer joeljfischer added this to To do in v6.6.0 Feb 7, 2020
v6.6.0 automation moved this from To do to Done Mar 16, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen
Projects
No open projects
v6.6.0
  
Done
Development

No branches or pull requests

2 participants