Avoid scroll jump #41962
Closed
Avoid scroll jump #41962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rafpaf
force-pushed
the
browse/breadcrumbs
branch
from
6dbb444
to
9a2ddaa
Compare
rafpaf
force-pushed
the
browse/avoid-scroll-jump
branch
from
0e2c8ab
to
cdf9283
Compare
rafpaf
force-pushed
the
browse/breadcrumbs
branch
from
9a2ddaa
to
ff24068
Compare
rafpaf
force-pushed
the
browse/avoid-scroll-jump
branch
from
cdf9283
to
e64bbe2
Compare
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This pull request addresses a visual issue related to toggling filters by adding a scrolling behavior to the 'BrowseModels' component.
What changed?
Additional Hooks and Context were introduced to manage the scrollable state of the viewport. The overflowY style attribute of the viewport is saved when the component is rendered and then set to 'scroll'. This style setting is then restored to its original value when the component is unmounted. This stops the page from 'jumping' when filters are toggled.
How to test?
Navigate to the component and toggle the filters to observe the updated behavior. The page should no longer 'jump' when filters are toggled.
Why make this change?
The change improves the user experience by reducing visual disruptions that may disorient users while interacting with the component.