Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid scroll jump #41962

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 25 additions & 1 deletion frontend/src/metabase/browse/components/BrowseModels.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { useEffect, useMemo, useState } from "react";
import { useContext, useEffect, useMemo, useRef, useState } from "react";
import { t } from "ttag";
import _ from "underscore";

import NoResults from "assets/img/no_results.svg";
import { useSearchQuery } from "metabase/api";
import LoadingAndErrorWrapper from "metabase/components/LoadingAndErrorWrapper";
import { ContentViewportContext } from "metabase/core/context/ContentViewportContext";
import Search from "metabase/entities/search";
import { color } from "metabase/lib/colors";
import { useDispatch } from "metabase/lib/redux";
Expand Down Expand Up @@ -36,6 +37,29 @@ export const BrowseModels = () => {
setActualModelFilters(initialModelFilters);
}, [initialModelFilters, setActualModelFilters]);

const contentViewportElement = useContext(ContentViewportContext);
const cachedViewportOverflowYRef = useRef<string>();

// Set the content viewport to scroll to prevent the page from jumping a little when filters are toggled
useEffect(() => {
if (!contentViewportElement) {
return;
}
cachedViewportOverflowYRef.current = getComputedStyle(
contentViewportElement,
).overflowY;
contentViewportElement.style.overflowY = "scroll";
return () => {
if (!contentViewportElement) {
return;
}
const cachedViewportOverflowY = cachedViewportOverflowYRef.current;
if (cachedViewportOverflowY) {
contentViewportElement.style.overflowY = cachedViewportOverflowY;
}
};
}, [contentViewportElement]);

return (
<BrowseContainer>
<BrowseHeader>
Expand Down