Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ItemsTable components to a higher-level folder #41952

Merged
merged 1 commit into from Apr 30, 2024
Merged

Move ItemsTable components to a higher-level folder #41952

merged 1 commit into from Apr 30, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Apr 29, 2024

Since ItemsTable will be used in Browse models, this PR moves that file and related components to metabase/components/ItemsTable.

@rafpaf rafpaf changed the base branch from master to browse/integration April 29, 2024 13:11
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Apr 29, 2024
@rafpaf rafpaf requested a review from a team April 29, 2024 13:12
@replay-io replay.io
Copy link

replay-io bot commented Apr 29, 2024 •
edited

Status Complete ↗︎
Commit 8494a93
Results
⚠️ 15 Flaky
✅ 2421 Passed

This was referenced Apr 29, 2024
Merged
Merged
@rafpaf Graphite App
Copy link
Contributor Author

rafpaf commented Apr 29, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

This was referenced Apr 29, 2024
Merged
Merged
Merged
Merged
Closed
Base automatically changed from browse/integration to master April 29, 2024 15:01
@rafpaf rafpaf mentioned this pull request Apr 29, 2024
Draft
@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label Apr 29, 2024
@rafpaf rafpaf merged commit 39ba519 into master Apr 30, 2024
133 of 134 checks passed
@rafpaf rafpaf deleted the table/refactor branch April 30, 2024 12:51
@rafpaf Graphite App
Copy link
Contributor Author

rafpaf commented Apr 30, 2024

Merge activity

@github-actions GitHub Actions
Copy link

@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@rafpaf rafpaf added this to the 0.50 milestone Apr 30, 2024
This was referenced Apr 30, 2024
Closed
Closed
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iethree iethree iethree approved these changes

Assignees

@rafpaf rafpaf

Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
0.50
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafpaf @iethree