Add table of models to the "Browse models" page #41614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
force-pushed
the
port-collections-to-ts
branch
from
986a3d6
to
7030fc7
Compare
rafpaf
force-pushed
the
browse/list
branch
2 times, most recently
from
5d6da8a
to
f27eab9
Compare
rafpaf
changed the title
rafpaf
force-pushed
the
browse/list
branch
2 times, most recently
from
fc086c8
to
3c0703f
Compare
|
rafpaf
changed the title
rafpaf
changed the base branch from
port-moderation-to-ts
to
custom-columns-in-ItemsTable
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
1dc0df9
to
0b35201
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 24, 2024
This was referenced May 1, 2024
rafpaf
added a commit
that referenced
this pull request
May 3, 2024
Lets the `ItemsTable` component have customizable columns. The logic for this is contained in `BaseItemsTable`. This is preliminary work for #41614 This doesn't introduce any new UI, but there is a unit test for the new logic. The main thing to check is whether the table on the collections page stills work correctly. Note how the columns adjust as you resize the viewport horizontally. (In fact, the columns will sometimes adjust as you close and open the sidebar, because the width they are paying attention to is the width of the area to the right of the sidebar.) Closes #41908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a table of models to the Browse models page.
Figma: https://www.figma.com/file/hubkgafXKo4wcBeTAbJ4vh/Browsing-Models-Exploration?type=design&node-id=252-22078&mode=design&t=Gmk1MAN7hCTDKM34-4
This PR also removes previously existing tab logic. Previously, the logic for retrieving models and retrieving databases was housed in a high-level component, BrowseApp. I moved the models-related logic into the component that displays the models and the database-related logic into the component that displays the databases.
For now, this table is pretty simple. We'll be iterating on it.