Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the tabs from Browse #41955

Merged
merged 2 commits into from May 3, 2024
Merged

Remove the tabs from Browse #41955

merged 2 commits into from May 3, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Apr 29, 2024 •
edited

Before:

image

After:

image

@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label Apr 29, 2024
@rafpaf rafpaf self-assigned this Apr 29, 2024
@rafpaf rafpaf changed the title Remove the tabs from Browse models Remove the tabs from Browse Apr 29, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Apr 29, 2024
@replay-io replay.io
Copy link

replay-io bot commented Apr 29, 2024 •
edited

Status In Progress ↗︎ 51 / 52
Commit f8de941
Results
❌ 16 Failed
⚠️ 8 Flaky
✅ 2429 Passed

@rafpaf rafpaf force-pushed the browse/no-tabs branch 2 times, most recently from fe56f82 to 52ab7a5 Compare April 29, 2024 14:30
@rafpaf rafpaf requested a review from camsaul as a code owner April 29, 2024 14:37
@rafpaf rafpaf mentioned this pull request Apr 29, 2024
Merged
@rafpaf Graphite App
Copy link
Contributor Author

rafpaf commented Apr 29, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

This was referenced Apr 29, 2024
Merged
Merged
Merged
Merged
Merged
Closed
@rafpaf rafpaf requested review from a team and removed request for camsaul April 29, 2024 16:18
npfitz
npfitz approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@npfitz npfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor comments that would be good to address before merging. But otherwise, looks good!

frontend/src/metabase/browse/components/BrowseSchemas.tsx Show resolved Hide resolved
frontend/src/metabase/browse/components/BrowseModels.tsx Show resolved Hide resolved
frontend/src/metabase/routes.jsx Show resolved Hide resolved
@rafpaf rafpaf force-pushed the browse/nav branch 2 times, most recently from d171255 to 544ca01 Compare April 30, 2024 18:04
@rafpaf rafpaf mentioned this pull request Apr 30, 2024
Closed
This was referenced May 1, 2024
Merged
Merged
@rafpaf rafpaf mentioned this pull request May 2, 2024
Open
@rafpaf rafpaf force-pushed the browse/no-tabs branch 2 times, most recently from e33d80d to 1d96541 Compare May 3, 2024 15:03
@rafpaf rafpaf force-pushed the browse/nav branch 4 times, most recently from 61be0e1 to 1bc8677 Compare May 3, 2024 17:49
@rafpaf rafpaf marked this pull request as draft May 3, 2024 18:13
@rafpaf rafpaf marked this pull request as ready for review May 3, 2024 18:13
@rafpaf rafpaf merged commit a3cd45d into browse/nav May 3, 2024
187 of 227 checks passed
@rafpaf rafpaf deleted the browse/no-tabs branch May 3, 2024 18:33
This was referenced May 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npfitz npfitz npfitz approved these changes

Assignees

@rafpaf rafpaf

Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
0.50
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafpaf @npfitz