Enable customization of columns in ItemsTable #41777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
b871c97
to
8aa0b5a
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
1dc0df9
to
0b35201
Compare
This was referenced Apr 24, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
8aa0b5a
to
e57912d
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
0b35201
to
3cfa500
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
e5c6796
to
e14d9f7
Compare
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
cd37bbc
to
2800551
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
e14d9f7
to
883e726
Compare
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
2800551
to
9357597
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
883e726
to
f693462
Compare
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
9357597
to
66a7792
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
f693462
to
03a93b4
Compare
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
66a7792
to
5e5777f
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
2 times, most recently
from
100de17
to
39852e1
Compare
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
5e5777f
to
795f33c
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
39852e1
to
1227958
Compare
rafpaf
force-pushed
the
port-moderation-to-ts
branch
from
795f33c
to
1cdb7da
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
353b2fa
to
3285b31
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
71854f7
to
f61d114
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
f61d114
to
53caf2c
Compare
rafpaf
commented
Apr 30, 2024
| @@ -64,7 +64,7 @@ class DraggedItems extends Component { | |||
| // necessary for decent drag performance | |||
| return ( | |||
| nextProps.items.length !== this.props.items.length || | |||
| nextProps.pinnedItems.length !== this.props.pinnedItems || | |||
| nextProps.pinnedItems.length !== this.props.pinnedItems.length || | |||
There was a problem hiding this comment.
@sloansparger Just wanted to flag this new substantive change. Somehow there was a new dragging performance issue introduced in this branch, and this fixes it
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
376770b
to
d76ef86
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
d76ef86
to
775f7e8
Compare
This was referenced May 1, 2024
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
775f7e8
to
a2bcf68
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
2 times, most recently
from
282f879
to
65df0fa
Compare
rafpaf
force-pushed
the
custom-columns-in-ItemsTable
branch
from
770a0da
to
e13b947
Compare
|
yikes, this PR seems to have done something to mess with z-indexes on the collection page. investigating now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets the
ItemsTablecomponent have customizable columns.The logic for this is contained in
BaseItemsTable. This is preliminary work for #41614This doesn't introduce any new UI, but there is a unit test for the new logic.
The main thing to check is whether the table on the collections page stills work correctly. Note how the columns adjust as you resize the viewport horizontally. (In fact, the columns will sometimes adjust as you close and open the sidebar, because the width they are paying attention to is the width of the area to the right of the sidebar.)
Closes #41908