Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Popover and user settings for filters #41959

Merged
merged 1 commit into from May 3, 2024
Merged

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Apr 29, 2024

Moves the filter settings on the Browse models page into a Popover

Under the hood, use user settings instead of localStorage for the filters

Before:

image

After:

image

Copy link

replay-io bot commented Apr 29, 2024

Status In Progress ↗︎ 51 / 52
Commit a8c81ce
Results
16 Failed
⚠️ 4 Flaky
2433 Passed

Copy link
Contributor

@npfitz npfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to see some unit tests around the new component, but otherwise it looks good

Base automatically changed from browse/list to browse/nav May 3, 2024 18:42
Copy link

github-actions bot commented May 3, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff 62e09eb...a8c81ce.

No notifications.

@rafpaf rafpaf merged commit 902ef11 into browse/nav May 3, 2024
14 checks passed
@rafpaf rafpaf deleted the browse/filters branch May 3, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants