Skip to content

Commit

Permalink
fix e2e test
Browse files Browse the repository at this point in the history
  • Loading branch information
rafpaf committed May 3, 2024
1 parent b074b74 commit 5f6c89f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion e2e/support/helpers/e2e-ui-elements-helpers.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function closeNavigationSidebar() {
appBar().findByTestId("sidebar-toggle").click();
}

export function browse() {
export function browseData() {
return navigationSidebar().findByLabelText("Browse data");
}

Expand Down
6 changes: 3 additions & 3 deletions e2e/test/scenarios/question/settings.cy.spec.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { SAMPLE_DB_ID } from "e2e/support/cypress_data";
import { SAMPLE_DATABASE } from "e2e/support/cypress_sample_database";
import {
browse,
browseData,
restore,
openOrdersTable,
openNavigationSidebar,
Expand Down Expand Up @@ -455,8 +455,8 @@ describe("scenarios > question > settings", () => {

// create a new question to see if the "add to a dashboard" modal is still there
openNavigationSidebar();
browse().click();
cy.findByRole("tab", { name: "Databases" }).click();
browseData().click();

// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy.contains("Sample Database").click();
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
Expand Down

0 comments on commit 5f6c89f

Please sign in to comment.