Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-spanner to v1.56.0 #139

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 27, 2020

This PR contains the following updates:

Package Update Change
com.google.cloud:google-cloud-spanner minor 1.53.0 -> 1.56.0

Release Notes

googleapis/java-spanner

v1.56.0

Compare Source

Features
Bug Fixes
Dependencies
1.55.1 (2020-05-21)
Bug Fixes
Dependencies
  • update dependency com.google.cloud:google-cloud-shared-dependencies to v0.4.0 (#​224) (2cf04aa)

v1.55.1

Compare Source

v1.55.0

Compare Source

Features
Bug Fixes
Dependencies
  • update dependency com.google.cloud:google-cloud-shared-dependencies to v0.3.1 (#​190) (ad41a0d)

v1.54.0

Compare Source

Features
  • deps: import shared-dependencies bom and use maven-flatten-plugin (#​172) (060a81a)
Bug Fixes

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 27, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #139 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
- Coverage     72.20%   72.18%   -0.02%     
  Complexity     1095     1095              
============================================
  Files            24       24              
  Lines          3292     3279      -13     
  Branches        495      481      -14     
============================================
- Hits           2377     2367      -10     
+ Misses          722      718       -4     
- Partials        193      194       +1     
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/jdbc/AbstractJdbcPreparedStatement.java 90.18% <0.00%> (-0.67%) 52.00% <0.00%> (ø%)
.../com/google/cloud/spanner/jdbc/JdbcConnection.java 49.45% <0.00%> (-0.28%) 42.00% <0.00%> (ø%)
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 95.23% <0.00%> (-0.01%) 180.00% <0.00%> (ø%)
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 73.91% <0.00%> (+0.11%) 91.00% <0.00%> (ø%)
...a/com/google/cloud/spanner/jdbc/JdbcResultSet.java 79.02% <0.00%> (+0.20%) 186.00% <0.00%> (ø%)
...le/cloud/spanner/jdbc/JdbcSqlExceptionFactory.java 46.37% <0.00%> (+0.66%) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42ebcc...4b67b45. Read the comment docs.

@renovate-bot renovate-bot force-pushed the renovate/spanner.test.version branch from 4abef86 to 7c5806a Compare June 19, 2020 02:25
@renovate-bot renovate-bot changed the title deps: update dependency com.google.cloud:google-cloud-spanner to v1.55.1 deps: update dependency com.google.cloud:google-cloud-spanner to v1.56.0 Jun 19, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 19, 2020
proto-google-cloud-spanner-v1 was duplicated.
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@skuruppu
Copy link
Contributor

The error is:

[WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for com.google.cloud:google-cloud-spanner:1.55.1 paths to dependency are:
+-com.google.cloud:google-cloud-spanner-jdbc:1.15.1-SNAPSHOT
  +-com.google.cloud:google-cloud-spanner:1.55.1
and
+-com.google.cloud:google-cloud-spanner-jdbc:1.15.1-SNAPSHOT
  +-com.google.cloud:google-cloud-spanner:1.56.0
, 
Require upper bound dependencies error for com.google.api.grpc:proto-google-cloud-spanner-admin-instance-v1:1.55.1 paths to dependency are:
+-com.google.cloud:google-cloud-spanner-jdbc:1.15.1-SNAPSHOT
  +-com.google.cloud:google-cloud-spanner:1.55.1
    +-com.google.api.grpc:proto-google-cloud-spanner-admin-instance-v1:1.55.1
and
+-com.google.cloud:google-cloud-spanner-jdbc:1.15.1-SNAPSHOT
  +-com.google.cloud:google-cloud-spanner:1.56.0
    +-com.google.api.grpc:proto-google-cloud-spanner-admin-instance-v1:1.55.1 (managed) <-- com.google.api.grpc:proto-google-cloud-spanner-admin-instance-v1:1.56.0
and
...

@forking-renovate
Copy link

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help.

The spanner.test.version should be equal to the compile version that is included in the imported bom. The separate version of the test library will no longer be needed when Spanner 1.55.2 is included in the libraries-bom, as that version should also include the test-jar of the Spanner client.
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 24, 2020
@olavloite
Copy link
Collaborator

The separate spanner.test.version should no longer be needed once Spanner 1.56.0 is in the libraries-bom (see #168 for a temporary draft)

@olavloite olavloite closed this Jun 24, 2020
@forking-renovate
Copy link

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (1.56.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate-bot renovate-bot deleted the renovate/spanner.test.version branch June 24, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants