Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove error message checking #183

Merged
merged 1 commit into from Apr 29, 2020
Merged

fix: remove error message checking #183

merged 1 commit into from Apr 29, 2020

Conversation

olavloite
Copy link
Collaborator

  • Removes specific error message checking, as the backend may change these without prior notice.
  • Removes warnings regarding deprected ExpectedException class.
  • Refactored to reuse the same table for most tests to reduce execution time.

Fixes #175

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
@olavloite
fix: remove error message checking
674a27e 
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
skuruppu
skuruppu approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you for the change.

@olavloite olavloite merged commit b477322 into master Apr 29, 2020
@olavloite olavloite deleted the issue-175 branch April 29, 2020 06:16
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
@jeanbza
regen (googleapis#183)
710ae3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu skuruppu approved these changes

@hengfengli hengfengli Awaiting requested review from hengfengli

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ITCommitTimestampTest.invalidColumnOptionValue check very specific error message
4 participants
@olavloite @skuruppu @googlebot @yoshi-kokoro