New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): import shared-dependencies bom and use maven-flatten-plugin #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any experience of how to configure this type of thing but the idea sounds great to me :)
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've added an ignore for m2e (Maven Eclipse plugin) to prevent errors when using this with Eclipse.
The build failure is caused by #179 |
* tests: run integration tests against emulator * test: run integration tests against emulator * chore: update name of workflow * test: skip test when there are no credentials * test: change to docker based emulator tests
com.google.cloud:google-cloud-shared-dependencies
to manage all common dependency versions forgoogle-cloud-*
clientspom.xml
that will be installed. It should resolve to the the same set of dependencies as if it were not flattened.Flattened pom.xml