Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create filter in correct order #180

Merged
merged 3 commits into from Apr 28, 2020
Merged

fix: create filter in correct order #180

merged 3 commits into from Apr 28, 2020

Conversation

olavloite
Copy link
Collaborator

Fixes #179

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 25, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2020
@olavloite
Copy link
Collaborator Author

@googlebot I consent.

hengfengli
hengfengli approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hengfengli
Copy link
Contributor

We probably should file the order of filter issue to the backend team.

@olavloite olavloite merged commit d80428a into master Apr 28, 2020
@olavloite olavloite deleted the issue-179 branch April 28, 2020 06:25
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
@jeanbza
Revert "regen (googleapis#179)" (googleapis#180)
eb59cef 
This reverts commit 8a5ba24.
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
b446d48 
…cies to v0.8.3 (googleapis#180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu skuruppu approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ListDatabaseOperations should filter on metadata type first, and then metadata field
5 participants
@olavloite @hengfengli @skuruppu @googlebot @yoshi-kokoro