Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ITCommitTimestampTest.invalidColumnOptionValue check very specific error message #175

Closed
skuruppu opened this issue Apr 23, 2020 · 0 comments · Fixed by #183
Closed

ITCommitTimestampTest.invalidColumnOptionValue check very specific error message #175

skuruppu opened this issue Apr 23, 2020 · 0 comments · Fixed by #183
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@skuruppu
Copy link
Contributor

The Spanner team reported that checking for specific error strings are error-prone as the returned string can change without notice.

I think they're specifically referring to this line:

java-spanner/google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITCommitTimestampTest.java

Line 192 in 5806b0e

expectedException.expectMessage("Errors parsing Spanner DDL statement");

If this can be fixed, that would be great.
@skuruppu skuruppu added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: spanner Issues related to the googleapis/java-spanner API. labels Apr 23, 2020
olavloite added a commit that referenced this issue Apr 25, 2020
@olavloite
fix: remove error message checking
a8732bc 
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
@olavloite olavloite mentioned this issue Apr 25, 2020
Merged
olavloite added a commit that referenced this issue Apr 28, 2020
@olavloite
fix: remove error message checking
674a27e 
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
olavloite added a commit that referenced this issue Apr 29, 2020
@olavloite
fix: remove error message checking (#183)
b477322 
* Removes specific error message checking, as the backend may change
  these without prior notice.
* Removes warnings regarding deprected ExpectedException class.
* Refactored to reuse the same table for most tests to reduce execution
  time.

Fixes #175
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this issue Nov 17, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
a553f79 
…cies to v0.8.2 (googleapis#175)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | patch | `0.8.1` -> `0.8.2` |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v0.8.2`](https://togithub.com/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#&#8203;082-httpswwwgithubcomgoogleapisjava-shared-dependenciescomparev081v082-2020-07-01)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v0.8.1...v0.8.2)

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-spanner-jdbc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove error message checking googleapis/java-spanner
2 participants
@skuruppu @olavloite