Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeginTransaction shouldn't retry indefinitely on FAILED_PRECONDITION #177

Closed
skuruppu opened this issue Apr 23, 2020 · 0 comments · Fixed by #181
Closed

BeginTransaction shouldn't retry indefinitely on FAILED_PRECONDITION #177

skuruppu opened this issue Apr 23, 2020 · 0 comments · Fixed by #181
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@skuruppu
Copy link
Contributor

A team reported that they're seeing BeginTransaction retrying indefinitely on FAILED_PRECONDITION errors.

This is an issue similar to #16. For now, just giving up on the retries for this specific error would do.

But perhaps we can consider not retrying for all non-retryable errors as well in a separate PR?
@skuruppu skuruppu added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. api: spanner Issues related to the googleapis/java-spanner API. labels Apr 23, 2020
olavloite added a commit that referenced this issue Apr 25, 2020
@olavloite
fix: stop preparing session on most errors
388827a 
Most errors that occur during preparing a session for a read/write
transaction should be considered permanent, and should stop the
automatic preparing of sessions. Any subsequent call to get a read/write
session will cause an in-process BeginTransaction RPC to be executed. If
the problem has been fixed in the meantime, the RPC will succeed and the
automatic prepare of sessions will start again. Otherwise, the error is
propagated to the user.

Fixes #177
@olavloite olavloite mentioned this issue Apr 25, 2020
Merged
olavloite added a commit that referenced this issue Apr 26, 2020
@olavloite
fix: stop preparing session on most errors
3cfe106 
Most errors that occur during preparing a session for a read/write
transaction should be considered permanent, and should stop the
automatic preparing of sessions. Any subsequent call to get a read/write
session will cause an in-process BeginTransaction RPC to be executed. If
the problem has been fixed in the meantime, the RPC will succeed and the
automatic prepare of sessions will start again. Otherwise, the error is
propagated to the user.

Fixes #177
olavloite added a commit that referenced this issue Apr 28, 2020
@olavloite
fix: stop preparing session on most errors (#181)
d0e3d41 
Most errors that occur during preparing a session for a read/write transaction should be considered permanent, and should stop the automatic preparing of sessions. Any subsequent call to get a read/write session will cause an in-process BeginTransaction RPC to be executed. If
the problem has been fixed in the meantime, the RPC will succeed and the automatic prepare of sessions will start again. Otherwise, the error is propagated to the user.

Fixes #177
ansh0l pushed a commit to ansh0l/java-spanner that referenced this issue Nov 10, 2022
@jeanbza
regen (googleapis#177)
9893573
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this issue Nov 17, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-spanner-…
1cf90af 
…jdbc to v1.16.0 (googleapis#177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stop preparing session on most errors googleapis/java-spanner
2 participants
@skuruppu @olavloite