Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add history results to autocomplete suggestions #4414

Merged
merged 12 commits into from Apr 30, 2024
Merged

Add history results to autocomplete suggestions #4414

merged 12 commits into from Apr 30, 2024

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Apr 10, 2024 •
edited

Task/Issue URL: https://app.asana.com/0/0/1206816228247411/f

Description

Steps to test this PR

Clear app data between tests, fire button doesn't clear history (yet)

Feature 1

  • Visit wikipedia.org
  • Type wiki
  • Check a history result is shown for wikipedia.org

Feature 2

Feature 3

  • Add a random site as a boomark
  • Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title
  • Type wiki
  • Check wikipedia is shown on the bottom section with a bookmark icon, not in top hits
  • Visit wikipedia.org
  • Check now wikipedia is shown in top hits with the bookmark icon

Feature 4

  • Add a random site as a favorite
  • Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title
  • Type wiki
  • Check now wikipedia is shown in top hits with the favorite icon

Feature 5

  • Type something on the search bar
  • Check history/bookmark/favorite suggestions aren't shown before search suggestions are loaded

Feature 6

  • Type something on the search bar
  • Quickly delete everything
  • Check history/bookmark/favorite suggestions aren't shown before search suggestions and no "No suggestions found" message is shown either

UI changes

wikipedia_history.mp4

This was referenced Apr 10, 2024
Open
Merged
Merged
Merged
@CrisBarreiro Graphite App
Copy link
Contributor Author

CrisBarreiro commented Apr 10, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro mentioned this pull request Apr 10, 2024
Merged
37 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch 3 times, most recently from c64c6c8 to c7af01b Compare April 10, 2024 17:12
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/store-history branch from 4a66f1f to 1796663 Compare April 10, 2024 17:26
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from c7af01b to a7ccf35 Compare April 10, 2024 17:27
@CrisBarreiro CrisBarreiro changed the base branch from feature/cbarreiro/autocomplete/store-history to feature/cbarreiro/extract-module April 10, 2024 17:27
@CrisBarreiro CrisBarreiro mentioned this pull request Apr 10, 2024
Merged
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/extract-module branch from 2bf76bb to 6b54bae Compare April 11, 2024 07:54
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from a7ccf35 to e0a7632 Compare April 11, 2024 07:54
@CrisBarreiro CrisBarreiro mentioned this pull request Apr 11, 2024
Merged
5 tasks
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/extract-module branch from 6b54bae to 0b1b50d Compare April 11, 2024 10:50
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from e0a7632 to fb7e00b Compare April 11, 2024 10:50
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/extract-module branch from 0b1b50d to cff4043 Compare April 11, 2024 15:23
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch 3 times, most recently from 23fa1e7 to f279378 Compare April 11, 2024 16:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/extract-module branch from 1257c87 to 31bddde Compare April 11, 2024 16:48
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from f279378 to bb917c9 Compare April 11, 2024 16:48
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/extract-module branch from 31bddde to 74e304d Compare April 12, 2024 08:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch 2 times, most recently from ad38129 to 398262e Compare April 12, 2024 08:59
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/extract-module branch from 74e304d to 2b66c89 Compare April 23, 2024 11:43
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from de9aced to 30e7102 Compare April 23, 2024 11:44
This was referenced Apr 23, 2024
Open
Open
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 30e7102 to 8ea83d2 Compare April 25, 2024 11:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/extract-module branch from d15364e to 17af83f Compare April 25, 2024 11:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 8ea83d2 to 68776eb Compare April 25, 2024 11:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 68776eb to 2f5c590 Compare April 25, 2024 14:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 2f5c590 to 1c41e69 Compare April 25, 2024 15:01
@CrisBarreiro CrisBarreiro marked this pull request as ready for review April 25, 2024 15:20
@CrisBarreiro CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-modules branch from 6aed08b to 27d7dc4 Compare April 29, 2024 14:30
Base automatically changed from feature/cbarreiro/extract-module to feature/cbarreiro/autocomplete/store-history April 29, 2024 15:52
@CrisBarreiro
Defer local results until remote ones are available (#4420)
e7b0759 
Task/Issue URL: https://app.asana.com/0/0/1206889126871834/f

### Description
 Defer local results until remote ones are available

### Steps to test this PR

_Feature 1_
- [ ] Type something on the search bar
- [ ] Check history/bookmark/favorite suggestions aren't shown before
search suggestions are loaded

_Feature 1_
- [ ] Type something on the search bar
- [ ] Quickly delete everything
- [ ] Check history/bookmark/favorite suggestions aren't shown before
search suggestions and no "No suggestions found" message is shown either
@CrisBarreiro CrisBarreiro merged commit 513086f into feature/cbarreiro/autocomplete/store-history Apr 30, 2024
4 checks passed
@CrisBarreiro CrisBarreiro deleted the feature/cbarreiro/autocomplete/history-modules branch April 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonfortep cmonfortep Awaiting requested review from cmonfortep

Assignees

@cmonfortep cmonfortep

Labels
STACKED PR - DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CrisBarreiro @cmonfortep