Add auto-complete support #4332

CrisBarreiro · 2024-03-20T10:04:48Z

Task/Issue URL: https://app.asana.com/0/0/1206816228247404/f

Description

Add autocomplete entries for results coming from navigation and SERP
Use different icons for bookmarks and favorites
Copy the scoring algorithm from BSK
Add support for bottom section
Add pixels for auto-complete
Store history
Add history results to autocomplete suggestions

Test pixel fired when selecting a favorite

Select a favorite from autocomplete
Check m_autocomplete_favorite_selection has been fired

Test pixel fired when selecting a bookmark

Select a bookmark from autocomplete
Checkk m_aut_s_b has been fired

Website (not SERP)

Visit a page (not SERP)
Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and isSerp is 0
Check there's an entry in visits_list with that same historyEntryId
Reload the page
Check the history_entries table still has only one entry for that site
Check the visits_list contains 2 entries for that same historyEntryId

SERP

Perform a search
Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and isSerp is 0
Check there's an entry in visits_list with that same historyEntryId
Reload the page
Check the history_entries table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different)
Check the visits_list contains 2 entries for that same historyEntryId

DuckDuckGo URL (not SERP)

Visit https://duckduckgo.com/settings
Open the history database using inspector or flipper, and check the query field is empty and isSerp is 0

Clear app data between tests, fire button doesn't clear history
(yet)

Feature 1

Visit wikipedia.org
Type wiki
Check a history result is shown for wikipedia.org

Feature 2

Visit https://en.wikipedia.org/wiki/Cat
Type wiki
Check there's no top hits result for Cat at wikipedia
Visit https://en.wikipedia.org/wiki/Cat 3 more times
Check there's a top hits result for Cat at wikipedia

Feature 3

Add a random site as a bookmark
Then go to bookmarks and edit it, Set https://wikipedia.org as the
URL and Wikipedia as the title
Type wiki
Check wikipedia is shown on the bottom section with a bookmark
icon, not in top hits
Visit wikipedia.org
Check now wikipedia is shown in top hits with the bookmark icon

Feature 4

Add a random site as a favorite
Then go to bookmarks and edit it, Set https://wikipedia.org as the
URL and Wikipedia as the title
Type wiki
Check now wikipedia is shown in top hits with the favorite icon

Feature 5

Type something on the search bar
Check history/bookmark/favorite suggestions aren't shown before
search suggestions are loaded

Feature 6

Type something on the search bar
Quickly delete everything
Check history/bookmark/favorite suggestions aren't shown before
search suggestions and no "No suggestions found" message is shown either

UI changes

Video

CrisBarreiro · 2024-03-20T10:05:06Z

Add auto-complete support #4332 : 2 dependent PRs (#4341 , #4450 ) 👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite

cmonfortep

quick pass on this one. We will discuss further today on zoom.

cmonfortep · 2024-05-06T15:48:57Z

app/src/main/java/com/duckduckgo/app/autocomplete/api/AutoComplete.kt

+        return history.asSequence().sortHistoryByRank(query)
+    }
+
+    @VisibleForTesting


I'm not a big fan of VisibleForTesting :D Taking a look at this one, should we move the score logic to its own class? Seems a good candidate to move into a AutocompleteScore, and have all that tricky logic there.

cmonfortep · 2024-05-06T16:05:39Z

app/src/main/java/com/duckduckgo/app/browser/pageloadpixel/PageLoadedHandler.kt

@@ -58,6 +60,7 @@ class RealPageLoadedHandler @Inject constructor(
                    ),
                )
            }
+            navigationHistory.saveToHistory(url, title)


I'm not sure about having this one here. In BrowserTabViewModel we have navigationStateChanged that should detect when a new page is visited and other state events. I think that's a good place to have all related events.

cmonfortep · 2024-05-15T09:24:14Z

history/history-impl/src/main/java/com/duckduckgo/history/impl/store/HistoryDao.kt

+
+@Dao
+interface HistoryDao {
+    @Transaction


do we need transaction here?

Yes, because we're using a Relation

…4341) Task/Issue URL: https://app.asana.com/0/0/1206816228247419/f ### Description Copy the scoring algorithm from BSK ### Steps to test this PR _Bookmarks shouldn't show in top hits (top section, above DDG suggestions)_ - [ ] Add wikipedia.org as a bookmark (not favorite) - [ ] Type wiki on the search bar - [ ] Check the newly added bookmark is not shown in top hits, and is instead shown in the bottom section (below DDG suggestions) _Favorites should show in top hits_ - [ ] Add wikipedia.org as a favorite - [ ] Type wiki on the search bar - [ ] Check the newly added favorite is shown in top hits and uses the bookmark+favorite icon ### Steps to test this PR _Test pixel fired when selecting a favorite_ - [ ] Select a favorite from autocomplete - [ ] Check m_autocomplete_favorite_selection has been fired _Test pixel fired when selecting a bookmark_ - [ ] Select a bookmark from autocomplete - [ ] Checkk m_aut_s_b has been fired _Website (not SERP)_ - [ ] Visit a page (not SERP) - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _SERP_ - [ ] Perform a search - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different) - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _DuckDuckGo URL (not SERP)_ - [ ] Visit https://duckduckgo.com/settings - [ ] Open the history database using inspector or flipper, and check the query field is empty and `isSerp` is 0 **Clear app data between tests, fire button doesn't clear history (yet)** _Feature 1_ - [ ] Visit wikipedia.org - [ ] Type wiki - [ ] Check a history result is shown for wikipedia.org _Feature 2_ - [ ] Visit https://en.wikipedia.org/wiki/Cat - [ ] Type wiki - [ ] Check there's no top hits result for Cat at wikipedia - [ ] Visit https://en.wikipedia.org/wiki/Cat 3 more times - [ ] Check there's a top hits result for Cat at wikipedia _Feature 3_ - [ ] Add a random site as a bookmark - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check wikipedia is shown on the bottom section with a bookmark icon, not in top hits - [ ] Visit wikipedia.org - [ ] Check now wikipedia is shown in top hits with the bookmark icon _Feature 4_ - [ ] Add a random site as a favorite - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check now wikipedia is shown in top hits with the favorite icon _Feature 5_ - [ ] Type something on the search bar - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions are loaded _Feature 6_ - [ ] Type something on the search bar - [ ] Quickly delete everything - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions and no "No suggestions found" message is shown either ### UI changes [Video](https://github.com/duckduckgo/Android/assets/6297834/645d3666-82a0-490a-9bf6-02901d14a117) ![favorites](https://github.com/duckduckgo/Android/assets/6297834/c142ec6b-ff0f-4ce9-8cc1-a1864d5a4de1) ![bookmarks](https://github.com/duckduckgo/Android/assets/6297834/945a9cb4-5f9d-4beb-9a07-953403d9251f)

CrisBarreiro requested a review from cmonfortep March 20, 2024 10:08

CrisBarreiro added the STACKED PR - DO NOT MERGE label Mar 20, 2024 — with Graphite App

CrisBarreiro marked this pull request as ready for review March 20, 2024 10:09

CrisBarreiro changed the title ~~Create entries for history pages and SERP~~ Create entries for history pages and SERP and update favorite icon Mar 21, 2024

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch from 0aa4b9a to 3ac0113 Compare March 21, 2024 15:29

This was referenced Mar 21, 2024

Add scoring algorithm for history suggestions (extracted from BSK) #4341

Merged

Add support for bottom section #4349

Merged

Add pixels for autocomplete #4357

Merged

Store history #4362

Merged

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch from 3ac0113 to 6aef9e2 Compare April 10, 2024 13:31

CrisBarreiro mentioned this pull request Apr 10, 2024

Add history results to autocomplete suggestions #4414

Merged

23 tasks

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch from 6aef9e2 to 461d2f9 Compare April 10, 2024 17:26

This was referenced Apr 10, 2024

Extract history to a new module #4416

Merged

Defer local results until remote ones are available #4420

Merged

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch from 461d2f9 to 3acb1a7 Compare April 11, 2024 10:49

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch from 3acb1a7 to b2b3469 Compare April 23, 2024 11:43

This was referenced Apr 23, 2024

Clear history entries from memory and database when clicking fire button #4450

Open

Schedule deletion of items older than 30 days #4451

Open

CrisBarreiro assigned cmonfortep Apr 25, 2024

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch 2 times, most recently from 08fb26f to cb0235c Compare May 2, 2024 09:16

CrisBarreiro mentioned this pull request May 2, 2024

Add RC flag for storing history #4495

Open

16 tasks

CrisBarreiro changed the title ~~Create entries for history pages and SERP and update favorite icon~~ Add auto-complete support May 3, 2024

CrisBarreiro mentioned this pull request May 14, 2024

Add in app message for autocomplete #4545

Draft

27 tasks

cmonfortep reviewed May 15, 2024

View reviewed changes

CrisBarreiro added 4 commits May 15, 2024 16:08

Create entries for history pages and SERP

b7003bd

Use different icons for bookmarks and favorites

c4378c2

Fix history items not correctly filtered

c2caede

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch from cb0235c to c2caede Compare May 15, 2024 14:08

Extract scoring logic out of Autocomplete

38500c8

CrisBarreiro force-pushed the feature/cbarreiro/autocomplete/history-entry branch from 34f2ced to 38500c8 Compare May 16, 2024 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add auto-complete support #4332

Add auto-complete support #4332

CrisBarreiro commented Mar 20, 2024 •

edited

CrisBarreiro commented Mar 20, 2024 •

edited

cmonfortep left a comment

cmonfortep May 6, 2024

cmonfortep May 6, 2024

cmonfortep May 15, 2024

CrisBarreiro May 15, 2024

Add auto-complete support #4332

Are you sure you want to change the base?

Add auto-complete support #4332

Conversation

CrisBarreiro commented Mar 20, 2024 • edited

Description

UI changes

CrisBarreiro commented Mar 20, 2024 • edited

cmonfortep left a comment

Choose a reason for hiding this comment

cmonfortep May 6, 2024

Choose a reason for hiding this comment

cmonfortep May 6, 2024

Choose a reason for hiding this comment

cmonfortep May 15, 2024

Choose a reason for hiding this comment

CrisBarreiro May 15, 2024

Choose a reason for hiding this comment

CrisBarreiro commented Mar 20, 2024 •

edited

CrisBarreiro commented Mar 20, 2024 •

edited