New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bottom section #4349
Add support for bottom section #4349
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on Graphite |
48ba947
to
ae7e07b
Compare
phrase = savedSite.url.toUri().toStringDropScheme(), | ||
title = savedSite.title, | ||
url = savedSite.url, | ||
isAllowedInTopHits = savedSite is Favorite, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant now, but will be needed later on, as bookmarks will be allowed in top hits in case they are a duplicate of a history item
1cd3d22
to
bc4dc30
Compare
8c14ea4
to
6b90bd5
Compare
bc4dc30
to
ea79429
Compare
6b90bd5
to
5b68c24
Compare
ea79429
to
84d0b35
Compare
5b68c24
to
0d3e8d8
Compare
84d0b35
to
f36a6ca
Compare
0d3e8d8
to
7f8a6d8
Compare
f36a6ca
to
e3836ef
Compare
Task/Issue URL: https://app.asana.com/0/0/1206816228247407/f ### Description Add pixels for autocomplete ### Steps to test this PR _Test pixel fired when selecting a favorite_ - [ ] Select a favorite from autocomplete - [ ] Check m_autocomplete_favorite_selection has been fired _Test pixel fired when selecting a bookmark_ - [ ] Select a bookmark from autocomplete - [ ] Checkk m_aut_s_b has been fired _Website (not SERP)_ - [ ] Visit a page (not SERP) - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _SERP_ - [ ] Perform a search - [ ] Open the history database using inspector or flipper, and check there's a new entry in `history_entries`. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and `isSerp` is 0 - [ ] Check there's an entry in `visits_list` with that same `historyEntryId` - [ ] Reload the page - [ ] Check the `history_entries` table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different) - [ ] Check the `visits_list` contains 2 entries for that same `historyEntryId` _DuckDuckGo URL (not SERP)_ - [ ] Visit https://duckduckgo.com/settings - [ ] Open the history database using inspector or flipper, and check the query field is empty and `isSerp` is 0 **Clear app data between tests, fire button doesn't clear history (yet)** _Feature 1_ - [ ] Visit wikipedia.org - [ ] Type wiki - [ ] Check a history result is shown for wikipedia.org _Feature 2_ - [ ] Visit https://en.wikipedia.org/wiki/Cat - [ ] Type wiki - [ ] Check there's no top hits result for Cat at wikipedia - [ ] Visit https://en.wikipedia.org/wiki/Cat 3 more times - [ ] Check there's a top hits result for Cat at wikipedia _Feature 3_ - [ ] Add a random site as a bookmark - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check wikipedia is shown on the bottom section with a bookmark icon, not in top hits - [ ] Visit wikipedia.org - [ ] Check now wikipedia is shown in top hits with the bookmark icon _Feature 4_ - [ ] Add a random site as a favorite - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the URL and Wikipedia as the title - [ ] Type wiki - [ ] Check now wikipedia is shown in top hits with the favorite icon _Feature 5_ - [ ] Type something on the search bar - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions are loaded _Feature 6_ - [ ] Type something on the search bar - [ ] Quickly delete everything - [ ] Check history/bookmark/favorite suggestions aren't shown before search suggestions and no "No suggestions found" message is shown either ### UI changes [No UI changes](https://github.com/duckduckgo/Android/assets/6297834/645d3666-82a0-490a-9bf6-02901d14a117)
a883f4c
into
feature/cbarreiro/autocomplete/history-score
Task/Issue URL: https://app.asana.com/0/0/1206840141125560/f
Description
Add support for bottom section. Auto-complete suggestions are divided as follows:
Steps to test this PR
Bookmarks shouldn't show in top hits (top section, above DDG suggestions)
Favorites should show in top hits
Steps to test this PR
Test pixel fired when selecting a favorite
Test pixel fired when selecting a bookmark
Website (not SERP)
history_entries
. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty andisSerp
is 0visits_list
with that samehistoryEntryId
history_entries
table still has only one entry for that sitevisits_list
contains 2 entries for that samehistoryEntryId
SERP
history_entries
. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, andisSerp
is 0visits_list
with that samehistoryEntryId
history_entries
table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different)visits_list
contains 2 entries for that samehistoryEntryId
DuckDuckGo URL (not SERP)
isSerp
is 0Clear app data between tests, fire button doesn't clear history
(yet)
Feature 1
Feature 2
Feature 3
URL and Wikipedia as the title
icon, not in top hits
Feature 4
URL and Wikipedia as the title
Feature 5
search suggestions are loaded
Feature 6
search suggestions and no "No suggestions found" message is shown either
UI changes
No UI changes