Store history

[CrisBarreiro]

Task/Issue URL: https://app.asana.com/0/1205008441501016/1206816228247418/f

Description

Steps to test this PR

Website (not SERP)

• Visit a page (not SERP)
• Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and isSerp is 0
• Check there's an entry in visits_list with that same historyEntryId
• Reload the page
• Check the history_entries table still has only one entry for that site
• Check the visits_list contains 2 entries for that same historyEntryId

SERP

• Perform a search
• Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and isSerp is 0
• Check there's an entry in visits_list with that same historyEntryId
• Reload the page
• Check the history_entries table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different)
• Check the visits_list contains 2 entries for that same historyEntryId

DuckDuckGo URL (not SERP)

• Visit https://duckduckgo.com/settings
• Open the history database using inspector or flipper, and check the query field is empty and isSerp is 0

Clear app data between tests, fire button doesn't clear history
(yet)

Feature 1

• Visit wikipedia.org
• Type wiki
• Check a history result is shown for wikipedia.org

Feature 2

• Visit https://en.wikipedia.org/wiki/Cat
• Type wiki
• Check there's no top hits result for Cat at wikipedia
• Visit https://en.wikipedia.org/wiki/Cat 3 more times
• Check there's a top hits result for Cat at wikipedia

Feature 3

• Add a random site as a bookmark
• Then go to bookmarks and edit it, Set https://wikipedia.org as the
  URL and Wikipedia as the title
• Type wiki
• Check wikipedia is shown on the bottom section with a bookmark
  icon, not in top hits
• Visit wikipedia.org
• Check now wikipedia is shown in top hits with the bookmark icon

Feature 4

• Add a random site as a favorite
• Then go to bookmarks and edit it, Set https://wikipedia.org as the
  URL and Wikipedia as the title
• Type wiki
• Check now wikipedia is shown in top hits with the favorite icon

Feature 5

• Type something on the search bar
• Check history/bookmark/favorite suggestions aren't shown before
  search suggestions are loaded

Feature 6

• Type something on the search bar
• Quickly delete everything
• Check history/bookmark/favorite suggestions aren't shown before
  search suggestions and no "No suggestions found" message is shown either

UI changes

wikipedia_history.mp4

[CrisBarreiro]

• Store history #4362 : 2 dependent PRs (#4414 , #4416 ) 👈
• Add pixels for autocomplete #4357
• Add support for bottom section #4349
• Add scoring algorithm for history suggestions (extracted from BSK) #4341
• Add auto-complete support #4332 : 1 other dependent PR (#4450 )
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite

[cmonfortep]

Left some comments. Focused mainly on the models as discussed. Happy to follow on them via zoom next week.

I'm gonna propose you to consider creating a module for history. TBH, what I see makes me think we should have a module with a public interface. We have our own db, we are defining what the api should be, etc.

The rest looks great to me, and I don't have major comments on the approach. Happy to chat more about this next week. I'm really excited with the feature 💯

[cmonfortep]

does it make sense that a search has title? Not sure if it's adding value here or if we are just interested on query and url.

[CrisBarreiro]

For the autocomplete feature, we don't really need a title, but I'm adding it anyways as other features might need it. The query and the title are slightly different. For example, if you search for "cat", query will be "cat", but title will be "cat at DuckDuckGo". I think it's best to keep both

[cmonfortep]

should we filter searches that are empty?

[CrisBarreiro]

Sure