Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add history results to autocomplete suggestions #4414

Merged
merged 12 commits into from
Apr 30, 2024
Merged

Add history results to autocomplete suggestions #4414

merged 12 commits into from
Apr 30, 2024

Commits on Apr 23, 2024

  1. Extract history to a new module

    @CrisBarreiro
    CrisBarreiro committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4d49ed5 View commit details
    Browse the repository at this point in the history

  2. Use LocalDateTime instead of Date in history entries

    @CrisBarreiro
    CrisBarreiro committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d6ff449 View commit details
    Browse the repository at this point in the history

  3. Fix HistoryDaoTest

    @CrisBarreiro
    CrisBarreiro committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1825b3d View commit details
    Browse the repository at this point in the history

  4. Rename HistoryApi to NavigationHistory

    @CrisBarreiro
    CrisBarreiro committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2b66c89 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Update readme

    @CrisBarreiro
    CrisBarreiro committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    17af83f View commit details
    Browse the repository at this point in the history

  2. Improve threading

    @CrisBarreiro
    CrisBarreiro committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    654e60b View commit details
    Browse the repository at this point in the history

  3. Add Foreign keys to VisitEntity

    @CrisBarreiro
    CrisBarreiro committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    728e419 View commit details
    Browse the repository at this point in the history

  4. Add history results to autocomplete suggestions

    @CrisBarreiro
    CrisBarreiro committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0945101 View commit details
    Browse the repository at this point in the history

  5. Fix issues with duplicates

    @CrisBarreiro
    CrisBarreiro committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e60c6fa View commit details
    Browse the repository at this point in the history

  6. Add tests for history items

    @CrisBarreiro
    CrisBarreiro committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1c41e69 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Sort all suggestions by score regardless of their type

    @CrisBarreiro
    CrisBarreiro committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    27d7dc4 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Defer local results until remote ones are available (#4420) 

    Task/Issue URL: https://app.asana.com/0/0/1206889126871834/f

### Description
 Defer local results until remote ones are available

### Steps to test this PR

_Feature 1_
- [ ] Type something on the search bar
- [ ] Check history/bookmark/favorite suggestions aren't shown before
search suggestions are loaded

_Feature 1_
- [ ] Type something on the search bar
- [ ] Quickly delete everything
- [ ] Check history/bookmark/favorite suggestions aren't shown before
search suggestions and no "No suggestions found" message is shown either
    @CrisBarreiro
    CrisBarreiro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e7b0759 View commit details
    Browse the repository at this point in the history