Add scoring algorithm for history suggestions (extracted from BSK)

[CrisBarreiro]

Task/Issue URL: https://app.asana.com/0/0/1206816228247419/f

Description

Copy the scoring algorithm from BSK

Steps to test this PR

Bookmarks shouldn't show in top hits (top section, above DDG suggestions)

• Add wikipedia.org as a bookmark (not favorite)
• Type wiki on the search bar
• Check the newly added bookmark is not shown in top hits, and is instead shown in the bottom section (below DDG suggestions)

Favorites should show in top hits

• Add wikipedia.org as a favorite
• Type wiki on the search bar
• Check the newly added favorite is shown in top hits and uses the bookmark+favorite icon

Steps to test this PR

Test pixel fired when selecting a favorite

• Select a favorite from autocomplete
• Check m_autocomplete_favorite_selection has been fired

Test pixel fired when selecting a bookmark

• Select a bookmark from autocomplete
• Checkk m_aut_s_b has been fired

Website (not SERP)

• Visit a page (not SERP)
• Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field is empty and isSerp is 0
• Check there's an entry in visits_list with that same historyEntryId
• Reload the page
• Check the history_entries table still has only one entry for that site
• Check the visits_list contains 2 entries for that same historyEntryId

SERP

• Perform a search
• Open the history database using inspector or flipper, and check there's a new entry in history_entries. Take note of the ID. Check the title field contains the same title as the tab, the query field contains your query, and isSerp is 0
• Check there's an entry in visits_list with that same historyEntryId
• Reload the page
• Check the history_entries table still has only one entry for that site (In some cases, reload doesn't produce the same exact query params,* in case a second entry is added, check URLs are different)
• Check the visits_list contains 2 entries for that same historyEntryId

DuckDuckGo URL (not SERP)

• Visit https://duckduckgo.com/settings
• Open the history database using inspector or flipper, and check the query field is empty and isSerp is 0

Clear app data between tests, fire button doesn't clear history
(yet)

Feature 1

• Visit wikipedia.org
• Type wiki
• Check a history result is shown for wikipedia.org

Feature 2

• Visit https://en.wikipedia.org/wiki/Cat
• Type wiki
• Check there's no top hits result for Cat at wikipedia
• Visit https://en.wikipedia.org/wiki/Cat 3 more times
• Check there's a top hits result for Cat at wikipedia

Feature 3

• Add a random site as a bookmark
• Then go to bookmarks and edit it, Set https://wikipedia.org as the
  URL and Wikipedia as the title
• Type wiki
• Check wikipedia is shown on the bottom section with a bookmark
  icon, not in top hits
• Visit wikipedia.org
• Check now wikipedia is shown in top hits with the bookmark icon

Feature 4

• Add a random site as a favorite
• Then go to bookmarks and edit it, Set https://wikipedia.org as the
  URL and Wikipedia as the title
• Type wiki
• Check now wikipedia is shown in top hits with the favorite icon

Feature 5

• Type something on the search bar
• Check history/bookmark/favorite suggestions aren't shown before
  search suggestions are loaded

Feature 6

• Type something on the search bar
• Quickly delete everything
• Check history/bookmark/favorite suggestions aren't shown before
  search suggestions and no "No suggestions found" message is shown either

UI changes

Video

[CrisBarreiro]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Store history #4362 : 2 dependent PRs (#4414 , #4416 )
• Add pixels for autocomplete #4357
• Add support for bottom section #4349
• Add scoring algorithm for history suggestions (extracted from BSK) #4341 👈
• Add auto-complete support #4332 : 1 other dependent PR (#4450 )
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite