Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoring algorithm for history suggestions (extracted from BSK) #4341

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    7f8a6d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Add support for bottom section (#4349)

    Task/Issue URL: https://app.asana.com/0/0/1206840141125560/f 
    
    ### Description
    Add support for bottom section. Auto-complete suggestions are divided as
    follows:
    1. Top hits (Top 2 results from favorites)
    2. Search suggestions
    3. Other favorites and bookmarks
    
    ### Steps to test this PR
    
    _Bookmarks shouldn't show in top hits (top section, above DDG
    suggestions)_
    - [ ] Add wikipedia.org as a bookmark (not favorite)
    - [ ] Type wiki on the search bar
    - [ ] Check the newly added bookmark is not shown in top hits, and is
    instead shown in the bottom section (below DDG suggestions)
    
    _Favorites should show in top hits_
    - [ ] Add wikipedia.org as a favorite
    - [ ] Type wiki on the search bar
    - [ ] Check the newly added favorite is shown in top hits and uses the
    bookmark+favorite icon
    
    ### Steps to test this PR
    
    _Test pixel fired when selecting a favorite_
    - [ ] Select a favorite from autocomplete
    - [ ] Check m_autocomplete_favorite_selection has been fired
    
    _Test pixel fired when selecting a bookmark_
    - [ ] Select a bookmark from autocomplete
    - [ ] Checkk m_aut_s_b has been fired
    
    _Website (not SERP)_
    - [ ] Visit a page (not SERP)
    - [ ] Open the history database using inspector or flipper, and check
    there's a new entry in `history_entries`. Take note of the ID. Check the
    title field contains the same title as the tab, the query field is empty
    and `isSerp` is 0
    - [ ] Check there's an entry in `visits_list` with that same
    `historyEntryId`
    - [ ] Reload the page
    - [ ] Check the `history_entries` table still has only one entry for
    that site
    - [ ] Check the `visits_list` contains 2 entries for that same
    `historyEntryId`
    
    _SERP_
    - [ ] Perform a search
    - [ ] Open the history database using inspector or flipper, and check
    there's a new entry in `history_entries`. Take note of the ID. Check the
    title field contains the same title as the tab, the query field contains
    your query, and `isSerp` is 0
    - [ ] Check there's an entry in `visits_list` with that same
    `historyEntryId`
    - [ ] Reload the page
    - [ ] Check the `history_entries` table still has only one entry for
    that site (In some cases, reload doesn't produce the same exact query
    params,* in case a second entry is added, check URLs are different)
    - [ ] Check the `visits_list` contains 2 entries for that same
    `historyEntryId`
    
    _DuckDuckGo URL (not SERP)_
    - [ ] Visit https://duckduckgo.com/settings
    - [ ] Open the history database using inspector or flipper, and check
    the query field is empty and `isSerp` is 0
    
    **Clear app data between tests, fire button doesn't clear history
    (yet)**
    
    _Feature 1_
    - [ ] Visit wikipedia.org
    - [ ] Type wiki
    - [ ] Check a history result is shown for wikipedia.org
    
    _Feature 2_
    - [ ] Visit https://en.wikipedia.org/wiki/Cat
    - [ ] Type wiki
    - [ ] Check there's no top hits result for Cat at wikipedia
    - [ ] Visit https://en.wikipedia.org/wiki/Cat 3 more times
    - [ ] Check there's a top hits result for Cat at wikipedia
    
    _Feature 3_
    - [ ] Add a random site as a bookmark
    - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the
    URL and Wikipedia as the title
    - [ ] Type wiki
    - [ ] Check wikipedia is shown on the bottom section with a bookmark
    icon, not in top hits
    - [ ] Visit wikipedia.org
    - [ ] Check now wikipedia is shown in top hits with the bookmark icon
    
    _Feature 4_
    - [ ] Add a random site as a favorite
    - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the
    URL and Wikipedia as the title
    - [ ] Type wiki
    - [ ] Check now wikipedia is shown in top hits with the favorite icon
    
    _Feature 5_
    
    - [ ] Type something on the search bar
    - [ ] Check history/bookmark/favorite suggestions aren't shown before
    search suggestions are loaded
    
    _Feature 6_
    - [ ] Type something on the search bar
    - [ ] Quickly delete everything
    - [ ] Check history/bookmark/favorite suggestions aren't shown before
    search suggestions and no "No suggestions found" message is shown either
    
    ### UI changes
    [No UI
    changes](https://github.com/duckduckgo/Android/assets/6297834/645d3666-82a0-490a-9bf6-02901d14a117)
    
    ![favorites](https://github.com/duckduckgo/Android/assets/6297834/c142ec6b-ff0f-4ce9-8cc1-a1864d5a4de1)
    
    ![bookmarks](https://github.com/duckduckgo/Android/assets/6297834/945a9cb4-5f9d-4beb-9a07-953403d9251f)
    CrisBarreiro committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a883f4c View commit details
    Browse the repository at this point in the history