Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-complete support #4332

Merged
merged 21 commits into from
Jun 5, 2024

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    2502fee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c7cb947 View commit details
    Browse the repository at this point in the history
  3. Add scoring algorithm for history suggestions (extracted from BSK) (#…

    …4341)
    
    Task/Issue URL: https://app.asana.com/0/0/1206816228247419/f
    
    Copy the scoring algorithm from BSK
    
    _Bookmarks shouldn't show in top hits (top section, above DDG
    suggestions)_
    - [ ] Add wikipedia.org as a bookmark (not favorite)
    - [ ] Type wiki on the search bar
    - [ ] Check the newly added bookmark is not shown in top hits, and is
    instead shown in the bottom section (below DDG suggestions)
    
    _Favorites should show in top hits_
    - [ ] Add wikipedia.org as a favorite
    - [ ] Type wiki on the search bar
    - [ ] Check the newly added favorite is shown in top hits and uses the
    bookmark+favorite icon
    
    _Test pixel fired when selecting a favorite_
    - [ ] Select a favorite from autocomplete
    - [ ] Check m_autocomplete_favorite_selection has been fired
    
    _Test pixel fired when selecting a bookmark_
    - [ ] Select a bookmark from autocomplete
    - [ ] Checkk m_aut_s_b has been fired
    
    _Website (not SERP)_
    - [ ] Visit a page (not SERP)
    - [ ] Open the history database using inspector or flipper, and check
    there's a new entry in `history_entries`. Take note of the ID. Check the
    title field contains the same title as the tab, the query field is empty
    and `isSerp` is 0
    - [ ] Check there's an entry in `visits_list` with that same
    `historyEntryId`
    - [ ] Reload the page
    - [ ] Check the `history_entries` table still has only one entry for
    that site
    - [ ] Check the `visits_list` contains 2 entries for that same
    `historyEntryId`
    
    _SERP_
    - [ ] Perform a search
    - [ ] Open the history database using inspector or flipper, and check
    there's a new entry in `history_entries`. Take note of the ID. Check the
    title field contains the same title as the tab, the query field contains
    your query, and `isSerp` is 0
    - [ ] Check there's an entry in `visits_list` with that same
    `historyEntryId`
    - [ ] Reload the page
    - [ ] Check the `history_entries` table still has only one entry for
    that site (In some cases, reload doesn't produce the same exact query
    params,* in case a second entry is added, check URLs are different)
    - [ ] Check the `visits_list` contains 2 entries for that same
    `historyEntryId`
    
    _DuckDuckGo URL (not SERP)_
    - [ ] Visit https://duckduckgo.com/settings
    - [ ] Open the history database using inspector or flipper, and check
    the query field is empty and `isSerp` is 0
    
    **Clear app data between tests, fire button doesn't clear history
    (yet)**
    
    _Feature 1_
    - [ ] Visit wikipedia.org
    - [ ] Type wiki
    - [ ] Check a history result is shown for wikipedia.org
    
    _Feature 2_
    - [ ] Visit https://en.wikipedia.org/wiki/Cat
    - [ ] Type wiki
    - [ ] Check there's no top hits result for Cat at wikipedia
    - [ ] Visit https://en.wikipedia.org/wiki/Cat 3 more times
    - [ ] Check there's a top hits result for Cat at wikipedia
    
    _Feature 3_
    - [ ] Add a random site as a bookmark
    - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the
    URL and Wikipedia as the title
    - [ ] Type wiki
    - [ ] Check wikipedia is shown on the bottom section with a bookmark
    icon, not in top hits
    - [ ] Visit wikipedia.org
    - [ ] Check now wikipedia is shown in top hits with the bookmark icon
    
    _Feature 4_
    - [ ] Add a random site as a favorite
    - [ ] Then go to bookmarks and edit it, Set https://wikipedia.org as the
    URL and Wikipedia as the title
    - [ ] Type wiki
    - [ ] Check now wikipedia is shown in top hits with the favorite icon
    
    _Feature 5_
    
    - [ ] Type something on the search bar
    - [ ] Check history/bookmark/favorite suggestions aren't shown before
    search suggestions are loaded
    
    _Feature 6_
    - [ ] Type something on the search bar
    - [ ] Quickly delete everything
    - [ ] Check history/bookmark/favorite suggestions aren't shown before
    search suggestions and no "No suggestions found" message is shown either
    
    [Video](https://github.com/duckduckgo/Android/assets/6297834/645d3666-82a0-490a-9bf6-02901d14a117)
    
    ![favorites](https://github.com/duckduckgo/Android/assets/6297834/c142ec6b-ff0f-4ce9-8cc1-a1864d5a4de1)
    
    ![bookmarks](https://github.com/duckduckgo/Android/assets/6297834/945a9cb4-5f9d-4beb-9a07-953403d9251f)
    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a173a11 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6bda95 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    615a485 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    519f7d8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc75a46 View commit details
    Browse the repository at this point in the history
  8. Allow bookmarks to be shown in top hits (#4572)

    Task/Issue URL: https://app.asana.com/0/0/1207300113417901/f 
    
    ### Description
    
    ### Steps to test this PR
    
    _Feature 1_
    - [ ] Do a clean install
    - [ ] Visit wikipedia.org
    - [ ] Save it as bookmark
    - [ ] Visit wikimedia.org
    - [ ] Save it as favorite
    - [ ] Use the fire button
    - [ ] Type wiki
    - [ ] Check wikimedia (favorite) is the first result in top hits, and
    wikipedia (bookmark) is the second
    
    
    _Feature 1_
    - [ ] Do a clean install
    - [ ] Visit wikipedia.org
    - [ ] Save it as bookmark
    - [ ] Type wiki
    - [ ] Check wikipedia is shown in top hits
    
    ### UI changes
    | Before  | After |
    | ------ | ----- |
    !(Upload before screenshot)|(Upload after screenshot)|
    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b20000f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    707e202 View commit details
    Browse the repository at this point in the history
  10. Clear history entries from memory and database when clicking fire but…

    …ton (#4450)
    
    Task/Issue URL:
    https://app.asana.com/0/1205008441501016/1206832755470649/f
    
    ### Description
    See title
    
    ### Steps to test this PR
    
    _Feature 1_
    - [ ] Visit wikipedia.org
    - [ ] Type wiki
    - [ ] Check wikipedia.org shows as a history suggestion
    - [ ] Press fire button
    - [ ] Type wiki again
    - [ ] Check wikipedia.org isn't shown as a history suggestion anymore
    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d3c6244 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    1567d54 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    717a32e View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    dc4bd88 View commit details
    Browse the repository at this point in the history
  14. Update settings

    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e88fb1a View commit details
    Browse the repository at this point in the history
  15. Fix CI issues

    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    69ffcce View commit details
    Browse the repository at this point in the history
  16. Optimize deletion

    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    55469ee View commit details
    Browse the repository at this point in the history
  17. Fix CI issues

    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    cf47bcf View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    34b847e View commit details
    Browse the repository at this point in the history
  19. Fix minor issues

    CrisBarreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    b004e64 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Remove top illustration

    CrisBarreiro committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e3d86d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    61e590a View commit details
    Browse the repository at this point in the history