New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenMapTiles 3.13 Features: Highway shields, Interstate filtering #72
Conversation
9aef2d8
to
888d5ed
Compare
Good catch, looks like I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General questions:
- Banners (TRK) seem to be commented out.
- Font sizes are all over the place. For instance, the PA keystone text is larger than others. Perhaps a maximum size based on certain common shields could help, e.g. no larger than the one used on Interstate/US routes?
style/js/shield.js
Outdated
/* | ||
if (typeof shieldDef.modifiers !== "undefined") { | ||
c = drawBanners(c, shieldDef.modifiers); | ||
} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are banners still a work in progress then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I forgot about those.
All dimensions are based on 1x 20px high canvas and are alway multiplied by current pixel ratio which will be either 1 or 2 if DPR is > 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Lets go! 🤠
Fixes #6
Fixes #69
Blocked by openmaptiles/openmaptiles#1287Update: OpenMapTiles 3.13 is released, MapTiler Cloud planet update is expected during the week of Jan 10, 2022.Blocked by maplibre/maplibre-gl-js#188 with pending fix maplibre/maplibre-gl-js#716. However, we can proceed with a development version of maplibre taken from that branch until it's released.
Description
This branch contains work that is dependent on the upcoming release of OpenMapTiles 3.13. This description will be updated over time with screen shots of the pending features. PRs that are dependent on OMT 3.13 can be posted to this branch. This PR will be kept in a "draft" status until OMT 3.13 is released.
Features included in this branch:
The following features are incomplete:
Caveats
This branch includes a development version of maplibre-gl-js taken from Shield rotation maplibre/maplibre-gl-js#716, which is incompatible with the license of openstreetmap-americana. This must be resolved prior to merging.(Resolved)How to run this branch
./quickstart <name of area>
to generate vector tiles (for example,./quickstart rhode-island
)make start-tileserver
which starts a tile server on localhost:8080make run
to run the styleScreen shots
Zoom 4 Interstate-only map of the US
Multiple-widths of highway shields (Interstates)
Highway shields, California
Highway shields, Minnesota
Highway shields, Pennsylvania
Highway shields, South Carolina
Highway shields, Vermont
Highway shields, Virginia
Triple-modifiers on US-30 in Pennsylvania
Test Areas (localhost-referenced):