Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfork GL JS #230

Closed
1ec5 opened this issue Mar 15, 2022 · 1 comment · Fixed by #277
Closed

Unfork GL JS #230

1ec5 opened this issue Mar 15, 2022 · 1 comment · Fixed by #277
Labels

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Mar 15, 2022

#72 forces shields to stay upright using the text-rotate-to-line layout property from the original version of maplibre/maplibre-gl-js#716. We’ve been depending on a fork of MapLibre GL JS for this functionality. Now that maplibre/maplibre-gl-js#716 has landed in main, we’ll be able to unfork the MapLibre GL JS dependency by the next release.

"maplibre-gl": "https://github.com/ZeLonewolf/maplibre-gl-js/releases/download/v2.0.5-americana-1/maplibre-gl-2.0.5-americana-1.tar.gz",
"text-rotate-to-line": false,

After rounds of code review, @wipfli settled on a different API design. We’ll need to migrate to "text-rotation-alignment": "viewport-glyph" instead of "text-rotate-to-line": false.

@1ec5 1ec5 added the shields label Mar 15, 2022
@wipfli
Copy link
Contributor

wipfli commented Mar 15, 2022

Looking forward to your feedback. You can use v2.1.8-pre.1 which has the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants