Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slovenia national road shield turned into a white rectangle #95

Closed
1ec5 opened this issue Jan 26, 2022 · 6 comments · Fixed by #98
Closed

Slovenia national road shield turned into a white rectangle #95

1ec5 opened this issue Jan 26, 2022 · 6 comments · Fixed by #98
Assignees
Labels

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Jan 26, 2022

Slovenia’s A1 motorway relation is tagged network=SI:AC, so it should show up as A1. Instead, it shows up as a generic white rectangle:

generic

@Mashin6 added a shield for the SI:AC network in 4a9c7a0, but it fell out of the branch for #72 at some point. The image is still present, but it’s unused. I wonder if this also accounts for the errors I see when zoomed out on Europe:

Uncaught RangeError: mismatched image size
    sa https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31
    la https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31
    clone https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31
    getGlyphs https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:35
    asyncAll https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31
    getGlyphs https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:35
    asyncAll https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31
    asyncAll https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31
    getGlyphs https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:35
    getGlyphs https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:35
    processTask https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31
    receive https://zelonewolf.github.io/openstreetmap-americana/js/maplibre-gl-custom-shields.js:31

Maybe someone force-pushed a commit, clobbering someone else’s, or maybe a merge conflict was resolved badly. I don’t think it’s possible to tell exactly what happened because of all the squash-merging that took place. We’ll probably want to go through the other commits to catch anything else that needs to be reapplied.

/ref #69

@1ec5 1ec5 added the bug Something isn't working label Jan 26, 2022
@1ec5
Copy link
Collaborator Author

1ec5 commented Jan 26, 2022

The image is still present, but it’s unused.

Incidentally, the ISO 3166 code for Slovenia is SI. SL is for Sierra Leone.

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 26, 2022

Same for Austria and Croatia.

@ZeLonewolf
Copy link
Owner

I think we clobbered them when we did all the point size fixes. It should just be a matter of restoring the definition code.

@ZeLonewolf
Copy link
Owner

Note that the original padding sizes will have to be shrunk now that @zekefarwell got everything down to actual-pixels numbers.

@zekefarwell
Copy link
Collaborator

Looks like #72 was merged in with a squash commit. Makes history hard to follow.

@zekefarwell zekefarwell self-assigned this Jan 26, 2022
@ZeLonewolf
Copy link
Owner

Looks like #72 was merged in with a squash commit. Makes history hard to follow.

My bad! Next time we'll do a proper protected feature branch for long-lead OMT features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants