Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the recolored shields that I broke #107

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

zekefarwell
Copy link
Collaborator

While refactoring in the lead up to #72 getting merged, I removed something that appeared redundant. This broke the recoloring of shields by adding an opaque background where it should be transparent. This PR fixes that.

Current broken rendering:
Screen Shot 2022-01-27 at 4 55 56 PM

Fixed rendering:
Screen Shot 2022-01-27 at 4 57 22 PM

Copy link
Owner

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I feel like there should be an easier way to do this but this works so let's ship it!

@ZeLonewolf ZeLonewolf merged commit 0df4a1d into main Jan 28, 2022
@ZeLonewolf ZeLonewolf deleted the fix-recolored-shields branch January 28, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants