Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

European road network #69

Closed
attilakundev opened this issue Dec 27, 2021 · 18 comments · Fixed by #72
Closed

European road network #69

attilakundev opened this issue Dec 27, 2021 · 18 comments · Fixed by #72

Comments

@attilakundev
Copy link

Referring to this conversation:
https://osmus.slack.com/archives/C01V02K52UX/p1640606101380400

@attilakundev
Copy link
Author

attilakundev commented Dec 27, 2021

https://www.openstreetmap.org/relation/2093784 an example European E-road relation (E75 in Hungary)
https://en.wikipedia.org/wiki/International_E-road_network
You can use the markers seen in Wikipedia because that is the most standard one

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 4, 2022

@ZeLonewolf
Copy link
Owner

If anyone is motivated to start working on adding these shields, #72 has instructions on how to do that prior to OMT 3.13 being available. PRs can be posted to the branch https://github.com/ZeLonewolf/openstreetmap-americana/tree/openmaptilers-new-features-test.

SVG artwork should be generated with a max size of 40px along the shortest dimension, with a recommended stroke size of 2.5px.

@1ec5
Copy link
Collaborator

1ec5 commented Jan 8, 2022

Some of the U.S. shields in #72 are derived from public domain images on Commons, so the images linked in #69 (comment) could be a good starting point.

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 10, 2022

image

@attilakundev
Copy link
Author

attilakundev commented Jan 10, 2022

@Mashin6 Looks nice!

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 15, 2022

Here is Hungary

@attilakundev
Copy link
Author

attilakundev commented Jan 15, 2022

Awesome! I guess then the primary route shields will be similar to this :D take a screenshot of route 3 - route 24 intersection in Gyöngyös please

@ZeLonewolf
Copy link
Owner

With @Mashin6's code updates to #72, this issue will close once the highway shields branch can be merged. Other shield networks that need to be rendered should open new issues with artwork samples.

@attilakundev
Copy link
Author

Alright, I checked the code, so i saw the HU:national there but since the network is kindof weird, since those which start with M are motorways, which doesn't have the M are green colored and not blue, like here: https://en.wikipedia.org/wiki/Main_road_3_(Hungary)#/media/File:3_(Hu)_Otszogletu_zold_tabla.svg

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 15, 2022

Yeah, those minor once should have a separate network like HU:primary or something like that.

@attilakundev
Copy link
Author

I don't know, I think Hungarians will stick to HU:national for those which are signed and HU:regional which are unsigned, so a filter like regex couldn't work for checking if the ref has the M or not?

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 15, 2022

@ZeLonewolf Maybe by hardcoding color replacement in shieldLighten() or some new function?

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 18, 2022

Switzerland
image

Italy
image

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 18, 2022

Czech Republic
image

@ZeLonewolf
Copy link
Owner

@ZeLonewolf Maybe by hardcoding color replacement in shieldLighten() or some new function?

That's the right idea. If the shields are the same design but just different colors, we can use the shieldLighten() approach, otherwise we would need to implement new functionality for returning a shields as a function of ref for special cases.

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 23, 2022

Austria
image

@Mashin6
Copy link
Contributor

Mashin6 commented Jan 24, 2022

Croatia:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants