Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shields for national expressways, national highways, and local highways in South Korea.
The national expressway shield is a little slice of home away from home. The shape is based on this sign blank on Wikimedia Commons, which is in the public domain. It’s very similar to the U.S. route shield, but the contours have subtle differences. It doesn’t leave very much room for the numerals, so ironically, local highways are much more prominent than national expressways.
The national highway shield is supposed to be an oval, even when a two-digit number would fit inside a circle, so I eschewed theroundedRectShield()
function in favor of a custom image. Unfortunately, spritezero turns the ellipse into a hendecagon.I’m unable to implement shields for metropolitan city roads and expressways. They are mapped as route relations, but the relations aren’t tagged with
network
. Instead, they’ve been added tonetwork
relations representing the highway system or the municipal government. We need them to be tagged withnetwork=KR:*
like the other route types so we can support them properly. Theref
s for Seoul’s special metropolitan city roads include both the signposted number and the non-signposted official number, which should go inunsigned_ref
.Along the way, this PR fixes an issue that caused routes with matching
network
s but missingref
s to appear as blank shields.Fixes #138.