Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate all tests from svFSIplus-Tests #95

Open
25 of 32 tasks
mrp089 opened this issue Sep 12, 2023 · 7 comments
Open
25 of 32 tasks

Integrate all tests from svFSIplus-Tests #95

mrp089 opened this issue Sep 12, 2023 · 7 comments
Labels
test Test features

Comments

@mrp089
Copy link
Member

mrp089 commented Sep 12, 2023

This issue keeps track of all tests that need to be added from https://github.com/SimVascular/svFSIplus-Tests.

  • 01-heat
    • 01-diffusion-line-source: 4bb3cb1
  • 02-lelas
    • 01-beam_Euler-Bernoulli (@zasexton)
      • 01-tet4 (N0{02, 04, 08, 12, 16, 32})
      • 02-hex8 (N0{02, 04, 08, 12, 16})
      • 03-tet10 (N012)
      • 04-hex20 (N008)
      • 05-hex27 (N008)
  • 03-stokes
    • 01-manufactured-solution: ca252b0
      • P1P1 (N{004, 008, 016, 032, 064, 128, 256})
      • P2P1 (N{004, 008, 016, 032, 064, 128})
  • 04-fluid
    • 01-pipe3D_RCR
    • 02-dye_AD: c14486e
    • 03-driven-cavity (2D): cbe1210
      04-closed-loop
      cplBC
      genBC
    • 05-nonNewtonian: c14486e
    • 06-iliac_artery
  • 05-struct
  • 06-ustruct
    • 01-block-compression (P1P1_VMS, P2P1)
    • 02-tensile-adventitia_HGO
    • 03-LV-Guccione-active
  • 07-fsi
    • ale
    • cmm: 9723a97
      • 01-pipe_RCR
        • 01-rigid
        • 02-deform-wall_inflate
          • 01-inflate
          • 02-CMM-inflate
        • 03-deform-wall_prestress
          • 01-prestress
          • 02-CMM-prestress
  • 08-cep
    • 01-2Dsqr_AP
    • 02-1Dcable_tTP
    • 03-benchmark_tTP
    • 04-2Dspiral_BO
  • 09-shells: 69a87f2
    • 01-plate
    • valve

Generated from running

tree  svFSI_examples -I "*.vtp|*.bin|*.vtu|histor.dat|*-procs*|*mesh*" -d
@mrp089 mrp089 added this to the Integration testing milestone Sep 12, 2023
@mrp089 mrp089 added the test Test features label Sep 12, 2023
@MatteoSalvador
Copy link
Collaborator

Thanks @mrp089! I think there is everything from the svFSIplus-Tests repository.
We will also add new tests coming from benchmark and realistic application along the way.

@mrp089
Copy link
Member Author

mrp089 commented Oct 3, 2023

I think we need to start putting test cases in separate folders because we're having too many for one (a great problem to have!). We could group them by physics, as in the Tests repository (but without the numbers in front).

We can also split up the pytest files by physics to make it more readable, similar to here. Every file starting with test_ will be executed by pytest. This will also make it easier to run subsets of the tests (e.g. only struct).

We could also label tests in the future as test (minimalistic, covering specific parts of the code) or example (demonstrating how to run certain problems). This way we can keep our pipeline quick by running some tests at every commit/pull request/merge and others only nightly/weekly.

@MatteoSalvador, let me know what you think.

@MatteoSalvador
Copy link
Collaborator

I agree @mrp089, I was discussing with @elenasmartinez that we would need to reorganize the tests because there are becoming too many!

@mrp089
Copy link
Member Author

mrp089 commented Oct 4, 2023

Ok! After #113 is merged, I'll do some restructuring.

@mrp089
Copy link
Member Author

mrp089 commented Jan 24, 2024

I updated the list, removing the GenBC tests since we didn't move it to svFSIplus. I also tagged @zasexton and @alexkaiser next to the tests they're working on.

The only unassigned item is now 09-shells. @ktbolt, we don't remember if that feature was moved to svFSIplus or if we decided against it. Do we need this test?

@ktbolt
Copy link
Collaborator

ktbolt commented Jan 24, 2024

@mrp089 I've added shells to svFSIplus and tested svFSI-Tests09-shells with both 01-plate and 02-valve, seems to have matched the svFSI results.

@mrp089
Copy link
Member Author

mrp089 commented Jan 24, 2024

Ok, great! Do you still have those input files? I can easily add them to the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test features
Projects
None yet
Development

No branches or pull requests

3 participants