Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize tests #140

Closed
wants to merge 5 commits into from
Closed

Re-organize tests #140

wants to merge 5 commits into from

Conversation

mrp089
Copy link
Member

@mrp089 mrp089 commented Nov 15, 2023

Current situation

Re-organized test cases as mentioned in #95 by physics:

  • separate test_*.py files
  • subfolders

Also, I simplified the test case definition:

  • removed redundant variables by using default names for input file, result file, and number of time steps
  • move test functions to conftest.py
  • move number of processors to conftest.py
  • use default tolerance of 1e-12

Release Notes

Should simplify adding new tests.

Documentation

We still need to add a documentation and testing guide.

Testing

Runs the same 75 tests as before that pass locally on Apple M2 (except cmm, as expected). I will verify that the coverage is the same once the GitHub actions are done.

Code of Conduct & Contributing Guidelines

@mrp089 mrp089 marked this pull request as draft November 15, 2023 07:44
@mrp089 mrp089 closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant