-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ustruct tests (P1P1-VMS block compression, tensile adventitia HGO, LV Guccione active) #113
Conversation
… guccione active)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @MatteoSalvador, I hit approve by accident! I leave my comments in a second/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On one core on the Ubuntu 20 GitHub runner, the tests take
block-compression
: 1.5 s (super fast, nicely done!)LV-Guccione-active
: 33 stensile_adventitia_HGO
: 28 s
Is there an easy way to coarsen the latter two geometries? Or even more radical, if we're just testing different materials with ustruct
, can we use a single element (which should be easy to set up)?
@MatteoSalvador, done with my comments! Thanks for taking the time to dig into how |
If there's an overlap with #115, can you reuse the geometries and just add a second input file? |
@mrp089 all |
With reference to #95, this MR introduces three tests for the ustruct formulation.