Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ustruct tests (P1P1-VMS block compression, tensile adventitia HGO, LV Guccione active) #113

Merged
merged 2 commits into from
Oct 4, 2023
Merged

ustruct tests (P1P1-VMS block compression, tensile adventitia HGO, LV Guccione active) #113

merged 2 commits into from
Oct 4, 2023

Conversation

MatteoSalvador
Copy link
Collaborator

With reference to #95, this MR introduces three tests for the ustruct formulation.

@mrp089 mrp089 self-requested a review September 28, 2023 23:31
Copy link
Member

@mrp089 mrp089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @MatteoSalvador, I hit approve by accident! I leave my comments in a second/

Copy link
Member

@mrp089 mrp089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LV displacements (here magnified by 1e5) look weird. It looks like only the apex deforms. Does the displacement make more sense if you run it for more time steps?
LV_displacement

Copy link
Member

@mrp089 mrp089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On one core on the Ubuntu 20 GitHub runner, the tests take

  • block-compression: 1.5 s (super fast, nicely done!)
  • LV-Guccione-active: 33 s
  • tensile_adventitia_HGO: 28 s

Is there an easy way to coarsen the latter two geometries? Or even more radical, if we're just testing different materials with ustruct, can we use a single element (which should be easy to set up)?

@mrp089
Copy link
Member

mrp089 commented Oct 2, 2023

@MatteoSalvador, done with my comments! Thanks for taking the time to dig into how ustruct works and setting up those tests!

@mrp089 mrp089 mentioned this pull request Oct 2, 2023
@mrp089
Copy link
Member

mrp089 commented Oct 4, 2023

If there's an overlap with #115, can you reuse the geometries and just add a second input file?

@MatteoSalvador
Copy link
Collaborator Author

@mrp089 all ustruct tests should run within a few seconds now.
I have also (re)checked that the numerical simulations over 100 time steps make sense.

@mrp089 mrp089 merged commit 6922927 into SimVascular:main Oct 4, 2023
4 checks passed
@MatteoSalvador MatteoSalvador deleted the ustruct_tests branch October 5, 2023 00:02
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
mrp089 referenced this pull request in mrp089/svFSIplus_old Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants