Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell test cases plate and valve #174

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

mrp089
Copy link
Member

@mrp089 mrp089 commented Jan 25, 2024

Current situation

Shells were added in #75, this PR adds the tests for them. Crossing off one more test in #95.

Release Notes

Meshes and setup from https://github.com/vvedula22/svFSI-Tests/tree/master/09-shells, xml input files provided by @ktbolt. I also fixed a bug in the error message reporting the number of nodes that are above the tolerance.

Documentation

None

Testing

  • Verified that C++ and FORTRAN results match by running both solvers and comparing the outputs in ParaView
  • Checked that the tests fail by outputting different time steps

Code of Conduct & Contributing Guidelines

@mrp089
Copy link
Member Author

mrp089 commented Jan 25, 2024

I'm putting this on draft until #173 has been addressed.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.24%. Comparing base (2fd02ed) to head (7773a30).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   57.70%   62.24%   +4.54%     
==========================================
  Files         103      103              
  Lines       26964    26964              
==========================================
+ Hits        15560    16785    +1225     
+ Misses      11404    10179    -1225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrp089
Copy link
Member Author

mrp089 commented Jan 25, 2024

From Codecov:

image

As intended, we brought coverage in shells.cpp from 0 to 69.86%!

@mrp089
Copy link
Member Author

mrp089 commented Jan 25, 2024

The original test also had a NURBS mesh. @ktbolt, is that currently supported, and should I add tests for that as well?

@ktbolt
Copy link
Collaborator

ktbolt commented Jan 25, 2024

@mrp089 NURBS are not supported.

@mrp089 mrp089 mentioned this pull request Feb 22, 2024
1 task
@mrp089 mrp089 marked this pull request as ready for review February 23, 2024 03:34
@MatteoSalvador MatteoSalvador merged commit 69a87f2 into SimVascular:main Feb 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants