Re-organize tests #141
Merged
Re-organize tests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoSalvador
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Terrific job @mrp089! I thoroughly looked at everything and I don't have further comments.
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* modify python * move cep * move cmm * move fluid * move fsi * move heats * mvoe stokes * move struct * move ustruct * move cep * move cep * fix move * fix name * fix cmm * fix run_with_reference call * fix relative paths
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* modify python * move cep * move cmm * move fluid * move fsi * move heats * mvoe stokes * move struct * move ustruct * move cep * move cep * fix move * fix name * fix cmm * fix run_with_reference call * fix relative paths
mrp089
referenced
this pull request
in mrp089/svFSIplus_old
Nov 30, 2023
* modify python * move cep * move cmm * move fluid * move fsi * move heats * mvoe stokes * move struct * move ustruct * move cep * move cep * fix move * fix name * fix cmm * fix run_with_reference call * fix relative paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
Re-organized test cases as mentioned in #95 by physics:
test_*.pyfilesAlso, I simplified the test case definition:
conftest.pyconftest.py1e-12Release Notes
Should simplify adding new tests.
Documentation
We still need to add a documentation and testing guide.
Testing
Runs the same 75 tests as before that pass locally on Apple M2 (except
cmm, as expected). After runninng the GitHub actions, I can see that the line coverage is the same as in the currentmainbranch.Code of Conduct & Contributing Guidelines