Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urllib3 1.24 #4830

Closed
nateprewitt opened this issue Oct 17, 2018 · 11 comments
Closed

Urllib3 1.24 #4830

nateprewitt opened this issue Oct 17, 2018 · 11 comments

Comments

@nateprewitt
Copy link
Member

Urllib3 released a new version today which has some breaking changes for Python 2.6. While we work out any other possible incompatibilities Requests will remain compatible with urllib3 1.21.1 to 1.23 for the next week.

If you’re experiencing issues due to pip’s dependency resolution, you will need to pin ˋurllib3==1.23` in your package requirements.

debraj-manna added a commit to debraj-manna/patroni that referenced this issue Oct 17, 2018
@laurentvv
Copy link

same problem with python 3.6 and urllib3 1.24 :
/usr/lib/python3.6/site-packages/requests/init.py:91: RequestsDependencyWarn ing: urllib3 (1.24) or chardet (3.0.4) doesn't match a supported version!
RequestsDependencyWarning)

Only warning don't block my program

@Lucas-C
Copy link

Lucas-C commented Oct 17, 2018

Same issue here, with this message during pip install :

requests 2.19.1 has requirement urllib3<1.24,>=1.21.1, but you'll have urllib3 1.24 which is incompatible.

and this error at execution time :

/usr/lib/python2.7/site-packages/gitlab/__init__.py:29: in <module>
    import requests
/usr/lib/python2.7/site-packages/requests/__init__.py:112: in <module>
    from . import utils
/usr/lib/python2.7/site-packages/requests/utils.py:24: in <module>
    from . import certs
E   ImportError: cannot import name certs

Pinning urllib3==1.23 worked as a workaround

@siphr
Copy link

siphr commented Oct 17, 2018

Pinned for workaround but hopefully this is not a permanent solution.

@Hrxn

This comment has been minimized.

@nateprewitt
Copy link
Member Author

@Hrxn, just to be clear, we’ve just crossed the 24 hour threshold since the urllib3 release. We’ve provided both a work around and posted a patch with the fix for review within hours. This is the same release process that’s been in place for a couple years now.

Going around demanding immediate action from projects that are run solely by volunteers isn’t going to get things done faster. It will be ready when we are confident it’s ready and not going to introduce additional problems to a very large ecosystem.

openstack-gerrit pushed a commit to cloud-bulldozer/browbeat that referenced this issue Oct 18, 2018
rally-openstack uses requests and requests has a requirement of urllib3 <1.24
urllib3 1.24 was released upstream for urllib3 which is incompatible with
requests.
So until psf/requests#4830 is resolved
Pinning urllib3 to 1.23.

Change-Id: I234709643b31ed87e2fd16ae65c616e3a8a83334
@ror6ax
Copy link

ror6ax commented Oct 18, 2018

My builds are now failing with

Collecting urllib3<1.24,>=1.21.1 (from requests->chancellor==0.0.5)
  Could not find a version that satisfies the requirement urllib3<1.24,>=1.21.1 (from requests->chancellor==0.0.5) (from versions: 1.24)

Not sure why the previous version can't be pulled by pip. Any suggestions?

@ror6ax

This comment has been minimized.

@sethmlarson
Copy link
Member

sethmlarson commented Oct 18, 2018

@ror6ax Breaking changes were known on urllib3's side before release. The issue being seen by many is that despite requests pinning the urllib3 version to <1.24,>=1.21.1 the newly released version is still being installed (perhaps by another dependency in the user's list that isn't restrained). Pip isn't a dependency resolver, this is why it's important to pin application dependencies (at a minimum!) and optionally use a tool with a real dependency resolver like Pipenv or Poetry.

@nateprewitt
Copy link
Member Author

nateprewitt commented Oct 18, 2018

Requests v2.20.0 has been uploaded to pypi.org. Issues should be resolved now. I'll leave this open for a bit for visibility, then close it out this evening.

@aakarshg
Copy link

Thank you @nateprewitt for getting on this and fixing the issue in under 72 hours :)

@ror6ax
Copy link

ror6ax commented Oct 18, 2018

Thanks @nateprewitt

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants