This repository has been archived by the owner on May 5, 2023. It is now read-only.
Remove upper bound constraint on urllib3 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incompatibility between urllib3 1.24 and requests is resolved.
brianquinlan
changed the title
brianquinlan
approved these changes
Mar 16, 2019
setup.py
Outdated
| @@ -28,7 +28,7 @@ | |||
|
|
|||
|
|
|||
| install_requires = [ | |||
| 'urllib3==1.23', # https://github.com/requests/requests/issues/4830 | |||
| 'urllib3>=1.23', | |||
There was a problem hiding this comment.
You could add <2 if you want to assume that they are fallowing semver.
brianquinlan
approved these changes
Mar 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incompatibility between urllib3 1.24 and requests is resolved. See psf/requests#4830
Fixes #310