Lock urllib3 to 1.23 until requests can use urllib3 1.24 and any issues with urllib3 1.24 in azkabancli are resolved #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reaks against requests and I am seeing indications that it breaks with azkabancli as well. This is to lock to the working version of urllib3==1.23 until all bugs against urllib3==1.24 within azkabancli and requests are resolved.
|
Thanks for the PR @Ralnoc; it looks like this is resolved now fortunately: psf/requests#4830 (comment). Could you confirm? |
|
It does appear to be the case. I'll go ahead and close this PR Request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 2018-10-16, urllib3 released backwards incompatible changes that breaks against requests and I am seeing indications that it breaks with azkabancli as well. This is to lock to the working version of urllib3==1.23 until all bugs against urllib3==1.24 within azkabancli and requests are resolved.