Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow suit of urllib3 and drop python2.6 #4829

Closed
wants to merge 1 commit into from
Closed

Follow suit of urllib3 and drop python2.6 #4829

wants to merge 1 commit into from

Conversation

asottile
Copy link

I used pyupgrade for the syntax changes. Most of the motivation was to resolve the urllib3 issue.

@nateprewitt
Copy link
Member

Hi @asottile, thanks for the pull request. As we noted in the urllib3 issue, this is already addressed and will be in our release within the next week once the changes in urllib3 have had some time to air out.

@nateprewitt
Copy link
Member

I’ve created #4830 for visibility. Thanks again @asottile!

@asottile
Copy link
Author

@nateprewitt disregarding the urllib3 issue -- is this PR not ok? does requests intend to support python2.6 (it doesn't test against it)

@asottile asottile deleted the drop_py26 branch October 17, 2018 02:46
@nateprewitt
Copy link
Member

There’s nothing wrong with the PR, but we already did this work a year ago. We haven’t supported python2.6 in a while but hadn’t intended to forcibly break compat until 3.0.0.

The reason we declined to merge this is it’s more work to rebase the release commits and would remove credit from the original author. It also introduces some breakages that will affect a number of our downstream dependencies which are unrelated to 2.6.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: No module named ordered_dict
2 participants