Skip to content

Commit

Permalink
Temporary fix to enable requests to work
Browse files Browse the repository at this point in the history
rally-openstack uses requests and requests has a requirement of urllib3 <1.24
urllib3 1.24 was released upstream for urllib3 which is incompatible with
requests.
So until psf/requests#4830 is resolved
Pinning urllib3 to 1.23.

Change-Id: I234709643b31ed87e2fd16ae65c616e3a8a83334
  • Loading branch information
aakarshg committed Oct 18, 2018
1 parent 1576642 commit 29acf22
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
10 changes: 10 additions & 0 deletions ansible/install/roles/browbeat/tasks/main.yml
Expand Up @@ -95,6 +95,16 @@
- heat-admin-id_rsa
when: "(tripleo == true and (hosts_file_exists.stat.exists == false or hosts_file_exists.stat.isreg == false))"

# Temporary fix until
# https://github.com/requests/requests/issues/4830
# is fixed upstream

- name: Install urllib3
pip:
name: urllib3
version: 1.23
virtualenv: "{{ browbeat_venv }}"

- name: Install requirements.txt into browbeat-venv
pip:
requirements: "{{ browbeat_path }}/requirements.txt"
Expand Down
10 changes: 10 additions & 0 deletions ansible/install/roles/rally/tasks/main.yml
Expand Up @@ -15,6 +15,16 @@
line: 'export REQUESTS_CA_BUNDLE={{ overcloud_ca_path }}'
when: overcloud_ca_path is defined

# Temporary fix until
# https://github.com/requests/requests/issues/4830
# is fixed upstream

- name: Install urllib3
pip:
name: urllib3
version: 1.23
virtualenv: "{{ rally_venv }}"

- name: Install Rally with OpenStack plugins into rally-venv
pip:
name: rally-openstack
Expand Down

0 comments on commit 29acf22

Please sign in to comment.