fix(deps): update dependency yargs to v16

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
yargs (source)	15.4.1 -> 16.2.0

---

Release Notes

yargs/yargs

v16.2.0

Compare Source

Features

• command() now accepts an array of modules (f415388)

Bug Fixes

• add package.json to module exports (#​1818) (d783a49), closes #​1817

16.1.1 (2020-11-15)

Bug Fixes

• expose helpers for legacy versions of Node.js (#​1801) (107deaa)
• deno: get yargs working on deno@1.5.x (#​1799) (cb01c98)

v16.1.1

Compare Source

v16.1.0

Compare Source

Features

• expose hideBin helper for CJS (#​1768) (63e1173)

Bug Fixes

• deno: update types for deno ^1.4.0 (#​1772) (0801752)
• exports: node 13.0-13.6 require a string fallback (#​1776) (b45c43a)
• modules: module path was incorrect (#​1759) (95a4a0a)
• positional: positional strings no longer drop decimals (#​1761) (e1a300f)
• make positionals in -- count towards validation (#​1752) (eb2b29d)

16.0.3 (2020-09-10)

Bug Fixes

• move yargs.cjs to yargs to fix Node 10 imports (#​1747) (5bfb85b)

16.0.2 (2020-09-09)

Bug Fixes

• typescript: yargs-parser was breaking @​types/yargs (#​1745) (2253284)

16.0.1 (2020-09-09)

Bug Fixes

• code was not passed to process.exit (#​1742) (d1a9930)

v16.0.3

Compare Source

v16.0.2

Compare Source

v16.0.1

Compare Source

v16.0.0

Compare Source

⚠ BREAKING CHANGES

• tweaks to ESM/Deno API surface: now exports yargs function by default; getProcessArgvWithoutBin becomes hideBin; types now exported for Deno.
• find-up replaced with escalade; export map added (limits importable files in Node >= 12); yarser-parser@19.x.x (new decamelize/camelcase implementation).
• usage: single character aliases are now shown first in help output
• rebase helper is no longer provided on yargs instance.
• drop support for EOL Node 8 (#​1686)

Features

• adds strictOptions() (#​1738) (b215fba)
• helpers: rebase, Parser, applyExtends now blessed helpers (#​1733) (c7debe8)
• adds support for ESM and Deno (#​1708) (ac6d5d1)
• drop support for EOL Node 8 (#​1686) (863937f)
• i18n for ESM and Deno (#​1735) (c71783a)
• tweaks to API surface based on user feedback (#​1726) (4151fee)
• usage: single char aliases first in help (#​1574) (a552990)

Bug Fixes

• yargs: add missing command(module) signature (#​1707) (0f81024), closes #​1704

Older CHANGELOG Entries

---

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[rpl]

This PR requires more changes to be ready to be merged:

• the tests are currently failing on the flow checks because of a Cannot resolve module yargs/yargs. [cannot-resolve-module] error (due to the code that is trying to import YargsParser from that module in src/program.js):
  https://travis-ci.org/github/mozilla/web-ext/jobs/727989542#L248
• we need to review more closely the breaking changes in this new major release and make sure we do have enough coverage to avoid regressions related to the command line parsing

[Rob--W]

@rpl

Cannot resolve module yargs/yargs. [cannot-resolve-module

That will be fixed in the next version of yargs (16.0.4?) by yargs/yargs#1747

[rpl]

@Rob--W so... I looked again to the issue in this update and unfortunately the only workaround that I did found to don't have to explicitly depend from a separate yargs-parser npm package was to import the yargs parser from the new file that is exporting it, that is yargs/build/index.cjs, unfortunately the workaround does not work on more recent nodejs versions (see details below).

I think that the other option is to add the explicit yargs-parser dependency and import the parser from there.
The main annoyance of this solution is that we will have to make sure yargs and yargs-parser deps does match (in other word that we do use the same yargs-parser version that yargs will be using internally).

---

Unfortunately this workaround (drafted in b1f2529) does work in nodejs v10, but it does still fail on nodejs v12 and nodejs v14 because that file is not explicitly exported by the yargs package:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './build/index.cjs' is not defined by "exports" in /home/circleci/web-ext/node_modules/yargs/package.

Link to the failures on circleci jobs:

• https://app.circleci.com/pipelines/github/mozilla/web-ext/182/workflows/75ed2071-3de5-4e1a-8f69-d9cc792c2d18/jobs/740/parallel-runs/0/steps/0-108
• https://app.circleci.com/pipelines/github/mozilla/web-ext/182/workflows/75ed2071-3de5-4e1a-8f69-d9cc792c2d18/jobs/741/parallel-runs/0/steps/0-108

[Rob--W]

Can't you just use yargs/yargs?

The Parser is intentionally exported (originally via yargs/yargs) to easily get a reference to the used parser, which is tested by https://github.com/yargs/yargs/blob/7ffb5e8ae4f4f94f94ffd10a3aa8b410b2ed2fe4/test/parser.cjs
(and introduced in yargs/yargs#1477). Oddly, the current version of the test doesn't reference yargs.js any more, since in yargs/yargs@ac6d5d1

But yargs/yargs.js is still exported:

• Node 12.7 and later via https://github.com/yargs/yargs/blob/v16.2.0/package.json#L6-L23
• Earlier node via https://github.com/yargs/yargs/blob/v16.2.0/yargs

... so I think that yargs/yargs should Just Work?

[rpl]

Can't you just use yargs/yargs?

The Parser is intentionally exported (originally via yargs/yargs) to easily get a reference to the used parser, which is tested by https://github.com/yargs/yargs/blob/7ffb5e8ae4f4f94f94ffd10a3aa8b410b2ed2fe4/test/parser.cjs
(and introduced in yargs/yargs#1477). Oddly, the current version of the test doesn't reference yargs.js any more, since in yargs/yargs@ac6d5d1

But yargs/yargs.js is still exported:

* Node 12.7 and later via https://github.com/yargs/yargs/blob/v16.2.0/package.json#L6-L23

* Earlier node via https://github.com/yargs/yargs/blob/v16.2.0/yargs

... so I think that yargs/yargs should Just Work?

hehe, thanks for pointing out that config, I saw it but while re-looking it I realized that the issue may be just that flow (at least the version being currently used) doesn't read that config from the package.json file and so it complains about it.

I updated the patch with the following changes:

• restored the yargs/yargs import
• temporarily supress flowtype error using a $FlowFixMe suppress comment

Flow suppress comments do raise a flowtype error if (e.g. after updating flow to a more recent version) there isn't a flow error to suppress, and that will make us aware that we can remove that suppress comment.

[codecov-io]

Codecov Report

Merging #2015 (1614e38) into master (c503895) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2015   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         1567      1567           
=========================================
  Hits          1567      1567           

Impacted Files	Coverage Δ
src/program.js	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c503895...1614e38. Read the comment docs.

[Rob--W]

r+c