Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make positionals in -- count towards validation #1752

Merged
merged 2 commits into from Sep 13, 2020

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Sep 11, 2020

@cspotcode this should return things to the old behavior.

Fixes #1732

Copy link
Contributor

@cspotcode cspotcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@bcoe bcoe merged commit eb2b29d into master Sep 13, 2020
@bcoe bcoe deleted the positionals-in-double-dash branch September 13, 2020 06:03
@bcoe
Copy link
Member Author

bcoe commented Oct 16, 2020

@cspotcode just released this to npm, let me know if you're continuing to bump into any issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

demand() ignores anything after --
2 participants